Change 13216

tjuricek
tjuricek committed this change into //guest/tjuricek/p4ws/stream/main/qt
Request Review
Download .zip
Change to a C++03 build.

Major changes:

1. QSharedPointer::create(...) is much more restricted than in C++11, so just use the .reset() method unless you're passing in a single const reference argument to the constructor.

2. Using Qt's foreach.

3. Replace lambdas with simpler helper methods. This seems to work, but we may have subtle memory issues I'm not 100% on top of yet.
  • Files 8
  • Comments 0
8 edited 0 added 0 deleted
p4_phoenix_services_client/CMakeLists.txt#5
Loading...
p4_phoenix_services_client/phoenix/PhoenixServicesClient.cpp#12
Loading...
p4_phoenix_services_client/phoenix/PhoenixServicesClient.h#9
Loading...
p4_phoenix_services_client/test/PhoenixProjectTests.cpp#2
Loading...
p4_phoenix_services_client/test/PhoenixServicesClientTests.cpp#6
Loading...
p4_project_services_client/CMakeLists.txt#2
Loading...
p4_project_services_client/p4_project_services/Branch.cpp#2
Loading...
p4_project_services_client/p4_project_services/Project.cpp#4
Loading...
Tip: Use n and p to cycle through the changes.