Change 1349
Overhaul to ChangeSorter implementation.
Member variables of ChangeSorter have
been made private, since nothing was (or should be) accessing them directly, and
methods, which remain public, should look the same from outside.
The original ChangeSorter was quick and dirty because I wanted to see P4HL working
quickly, but it was also about as inefficient as possible because it used single links
and linear searches.
The new and improved ChangeSorter is a doubly-linked list with intelligent searching
that's geared toward sequential access of elements that are close to each other, which
is indeed the nature of most of the queries that P4HL makes. Even in a worst-case
scenario, this version should perform at least as well as the old one.
No noticeable performance change or bugs as of yet, but in theory we'd see the difference
with really large sets of data (ones larger than P4HL can show us).
Member variables of ChangeSorter have
been made private, since nothing was (or should be) accessing them directly, and
methods, which remain public, should look the same from outside.
The original ChangeSorter was quick and dirty because I wanted to see P4HL working
quickly, but it was also about as inefficient as possible because it used single links
and linear searches.
The new and improved ChangeSorter is a doubly-linked list with intelligent searching
that's geared toward sequential access of elements that are close to each other, which
is indeed the nature of most of the queries that P4HL makes. Even in a worst-case
scenario, this version should perform at least as well as the old one.
No noticeable performance change or bugs as of yet, but in theory we'd see the difference
with really large sets of data (ones larger than P4HL can show us).