Change 32492

russell_jackson (Russell C. Jackson (Rusty))
Russell C. Jackson (Rusty) committed this change into //guest/russell_jackson/ansible-sdp
Request Review
Download .zip
Fix bugs, remove orphaned files, and apply best practices to ansible-sdp

- Fix broken Jinja2 filter syntax (|bool|) in main-playbook.yml
- Fix target_server logic comparing string literals instead of variables
- Fix package install failing on RedHat due to missing OS family guard
- Split packages into OS-agnostic and Debian-specific lists, remove duplicates
- Switch all binary downloads from HTTP to HTTPS
- Remove 7 orphaned files (unused templates, scripts, configs)
- Replace hardcoded emails in cron with template variables
- Fix inconsistent journal rotations (06:00/08:00) to use rotate_journal.sh
- Parameterize admin sudoers and perforce user password
- Fix ansible.cfg malformed vars block
- Fix ansibleuser sudo group for RedHat (wheel) vs Debian (sudo)
- Remove redundant triple broker start/restart in install.yml
- Replace shell sed with ansible.builtin.replace in monitoring role
- Fix duplicate handler and undefined variable in monitoring handlers
- Use notify handlers instead of inline commands for sysctl/THP
- Add idempotency (creates:) to pyenv install
  • Files 20
  • Comments 0
13 edited 0 added 7 deleted
ansible.cfg#2
Loading...
inventories/group_vars/central/main.yml#2
Loading...
inventories/host_vars/perforce-commit.yml#2
Loading...
main-playbook.yml#2
Loading...
roles/perforce-sdp-install/defaults/main.yml#2
Loading...
roles/perforce-sdp-install/tasks/cron.yml#2
Loading...
roles/perforce-sdp-install/tasks/dependencies.yml#2
Loading...
roles/perforce-sdp-install/tasks/install.yml#2
Loading...
roles/perforce-sdp-install/tasks/install_broker.yml#2
Loading...
roles/perforce-sdp-install/tasks/main.yml#2
Loading...
roles/perforce-sdp-install/tasks/update.yml#2
Loading...
roles/perforce-sdp-monitoring/files/auditd_post_start#2
Loading...
roles/perforce-sdp-monitoring/files/otelcol-contrib.conf#2
Loading...
roles/perforce-sdp-monitoring/files/smartmon.sh#2
Loading...
roles/perforce-sdp-monitoring/handlers/main.yml#2
Loading...
roles/perforce-sdp-monitoring/tasks/main.yml#2
Loading...
roles/perforce-sdp-monitoring/templates/audit.rules.j2#2
Loading...
roles/perforce-sdp-monitoring/templates/nexpose_sudoer.j2#2
Loading...
roles/perforce-sdp-monitoring/templates/p4prometheus_config.j2#2
Loading...
roles/perforce-sdp-monitoring/templates/p4prometheus_systemd.j2#2
Loading...
Tip: Use n and p to cycle through the changes.