Change 32506

russell_jackson (Russell C. Jackson (Rusty))
Russell C. Jackson (Rusty) committed this change into //guest/russell_jackson/sdp/Server/Windows/p4/common/bin
Request Review
Download .zip
changed in Invoke-TruncateJournal (line ~501):

Before: The function only checked for $script:SERVER_TYPE -eq "p4d_master" and did nothing for other server types — edge/replica/standby servers would silently skip journal handling entirely.                                 

After: The function now has three branches:                                                                                                                                                                                     

1. Edge/replica/standby (checked first via $script:EDGESERVER, $script:REPLICASERVER, $script:STANDBYSERVER): Skips p4 admin journal rotation entirely, logs that it's waiting, and polls for the already-rotated
journal file to appear via replication (same 30-minute timeout as the master path).
     2. Master (p4d_master): Unchanged behavior — validates no duplicate files exist, rotates the journal, waits for the file.                                                                                                       
3. Unknown server type (fallback): Logs a warning and proceeds with rotation as if it were a master, so the script doesn't silently fail on unrecognized configurations.                                                       

The Get-JournalNum function already correctly adjusts the journal number for edge/replica/standby (subtracts 1 since the counter is already incremented by the replicated rotation), so no changes were needed there.
  • Files 1
  • Comments 0
1 edited 0 added 0 deleted
daily_checkpoint.ps1#3
Loading...
Tip: Use n and p to cycle through the changes.