Change 32709
Bug hunt with Claude
Justification:
rotate_journal.sh � Calls p4login with an absolute path instead of via $P4CBIN
/p4/common/bin/p4login
Other scripts in the codebase use "$P4CBIN/p4login". This one hard-codes the path, which breaks in any non-standard SDP layout or when P4CBIN is customized. daily_checkpoint.sh correctly uses "$P4CBIN"/p4login. This is an inconsistency that constitutes a latent bug in non-default deployments.
Justification:
rotate_journal.sh � Calls p4login with an absolute path instead of via $P4CBIN
/p4/common/bin/p4login
Other scripts in the codebase use "$P4CBIN/p4login". This one hard-codes the path, which breaks in any non-standard SDP layout or when P4CBIN is customized. daily_checkpoint.sh correctly uses "$P4CBIN"/p4login. This is an inconsistency that constitutes a latent bug in non-default deployments.