Change 32713

mark_zinthefer (Mark Zinthefer)
Mark Zinthefer committed this change into //guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin
Request Review
Download .zip
Fix two bugs in backup_functions.sh

Bug 1 (stop_p4broker timeout message): In stop_p4broker(), the timeout
error message referenced $maxStartDelay, which is undefined in that
function. The correct local variable is $maxStopDelay (declared at the
top of stop_p4broker()). With set -u active in the script, hitting this
code path would crash the script with an unbound variable error instead
of printing the intended timeout message. The equivalent code in
stop_p4d() and stop_p4p() correctly uses $maxStopDelay.

Bug 2 (typo in check_vars error message): The error message on line 75
read 'Aborting to to errors' (doubled word). Corrected to 'Aborting due
to errors'.
  • Files 1
  • Comments 0
1 edited 0 added 0 deleted
backup_functions.sh#174
Loading...
Tip: Use n and p to cycle through the changes.