Change 33167
Fix PreflightAbort test in cli_tests.cfg: install_sdp.sh in //p4-sdp/dev_rebrand now defaults to /opt/perforce/p4-sdp (SDP-1379 Helix->P4 rebranding already landed there), not /opt/perforce/helix-sdp.
The test's setup step still created the old path, so its precondition for the expected abort never actually matched, and the test silently passed through instead of aborting as expected. Found while running the full suite on the r9x86_64 canary (Task 1.3). Note: many other cli_tests.cfg test groups further down still reference /opt/perforce/helix-sdp and helix_binaries -- this fix only addresses the one test actually reached so far; a fuller audit is likely needed as more of the suite is exercised against dev_rebrand.
Agent: Claude Code, Model: Claude Sonnet 5 (claude-sonnet-5), operating as bot_Claude_Anthropic.
The test's setup step still created the old path, so its precondition for the expected abort never actually matched, and the test silently passed through instead of aborting as expected. Found while running the full suite on the r9x86_64 canary (Task 1.3). Note: many other cli_tests.cfg test groups further down still reference /opt/perforce/helix-sdp and helix_binaries -- this fix only addresses the one test actually reached so far; a fuller audit is likely needed as more of the suite is exercised against dev_rebrand.
Agent: Claude Code, Model: Claude Sonnet 5 (claude-sonnet-5), operating as bot_Claude_Anthropic.