Change 33182
bootstrap_test_machine.sh: also cache the Sample Depot tarball, so a fresh machine is actually test-ready.
bootstrap_test_machine.sh's own doc-comment claimed it handles "everything
through having a fully working shell environment", but it never called
init_root_dirs_for_local_installs.sh -- so /root/downloads (the Sample
Depot tarball cache) was never populated on a genuinely fresh machine,
and every Sample-Depot-touching test group (and everything cascading
after it, given run_cli_tests.sh's -e) would fail immediately with an
undocumented rsync error. Caught this rolling the updated bootstrap out
to the 6 remaining fleet machines tonight.
Verified end-to-end on a fully wiped-clean r9x86_64: a single
'bootstrap_test_machine.sh -mode basic' run now populates both
/root/p4_binaries and /root/downloads with no separate manual step.
Agent: Claude Code (Sonnet 5, claude-sonnet-5)
bootstrap_test_machine.sh's own doc-comment claimed it handles "everything
through having a fully working shell environment", but it never called
init_root_dirs_for_local_installs.sh -- so /root/downloads (the Sample
Depot tarball cache) was never populated on a genuinely fresh machine,
and every Sample-Depot-touching test group (and everything cascading
after it, given run_cli_tests.sh's -e) would fail immediately with an
undocumented rsync error. Caught this rolling the updated bootstrap out
to the 6 remaining fleet machines tonight.
Verified end-to-end on a fully wiped-clean r9x86_64: a single
'bootstrap_test_machine.sh -mode basic' run now populates both
/root/p4_binaries and /root/downloads with no separate manual step.
Agent: Claude Code (Sonnet 5, claude-sonnet-5)