Change 33435

bot_Claude_Anthropic (Claude (AI Agent by Anthropic))
Claude (AI Agent by Anthropic) committed this change into //p4-sdp/main/tools
Request Review
Download .zip
Fix gen_file_format_check.sh: stale hardcoded Classic-depot paths, and a copy-paste VersionID bug (release process Step 12).

Found while exercising Step 12 for real: all 4 'p4 grep' queries were
hardcoded to the frozen //guest/perforce_software/sdp/dev/... Classic
path, meaning this check silently validated against stale content instead
of the current stream -- it happened to pass, but wasn't actually
checking what it claimed to. Now resolves the current stream dynamically
(same $ThisWorkspace/$ThisStream pattern used elsewhere in this release
process) and checks against that instead.

Also fixed the VersionID line, which was a literal, unexpanded copy-paste
from mkrep.sh (this file lacked the +k filetype modifier its own comment
says it relies on, so the RCS keyword never actually expanded). Added +k
and reset VersionID to the standard unexpanded '$Id$ $Change$' form.

Agent: Claude Code, Model: Claude Sonnet 5 (claude-sonnet-5), operating as bot_Claude_Anthropic.
  • Files 1
  • Comments 0
1 edited 0 added 0 deleted
gen_file_format_check.sh#2
Loading...
Tip: Use n and p to cycle through the changes.