#!perl -w # Copyright (C) 1997 Capella Computers Ltd. # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License # as published by the Free Software Foundation; either version 2 # of the License, or (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. # :FILE: # Fail a reviewed job; additional work should be done by the developer. use strict; use English; use P4; # Takes (optional) job id. sub usage { P4::crash("Usage: p4rfail []"); } # Parse command line. my $job; if ($#ARGV < 0) { $job = P4::current_job(); } elsif ($ARGV[0] eq '-h') { usage(); } elsif ($ARGV[0] =~ /^\d+$/) { $job = shift(@ARGV); } if ($#ARGV >= 0) { usage(); } # Verify quick pre-conditions. P4::verify_current_user(0, 'integ'); # Lock job to avoid race conditions. P4::lock($job, 'p4rfail'); # Obtain the job record. my %record = P4::job_record($job); # Verify pre-conditions. Note that we allow a reviewer to OK a job # which has been declared OK (possibly by another reviewer), or even # a job which has been declared a failure by another reviewer. In # short, the last reviewer's entry wins. my $status = $record{status}; P4::verify_job_status($job, \%record, 'review', 'pass', 'fail'); # We should really prevent a user from reviewing himself. However, # since it is trivial to hack the system (e.g., by just setting P4USER # to someone else), there wouldn't be much point in it. # Update the job record, overwriting the state and the reviewer's identity. my $reviewer = P4::current_user(); $record{reviewer} = $reviewer; $record{status} = 'fail'; P4::update_job($job, \%record); # Release obtained locks. P4::unlock(); # Notify caller. my $user = $record{user}; my $retry = $record{retry}; print "Job $job (attempt #$retry) ", "has been returned to $user for further work.\n"; # Be nice. 1;