var Evaluator = require('esmangle-evaluator'); var recast = require('recast'); var types = recast.types; var b = types.builders; var VISITOR_METHODS = { visitLogicalExpression: visitLogicalExp, visitIfStatement: visitCondition, visitConditionalExpression: visitCondition }; module.exports = function(branch) { recast.visit(branch, VISITOR_METHODS); return branch; }; /** * "||" and "&&" */ function visitLogicalExp(path) { var leftEval = Evaluator.booleanCondition(path.node.left); if (typeof leftEval !== 'boolean') { // console.log('___ %s ___', path.node.operator); this.traverse(path); return; } var leftSideEffect = Evaluator.hasSideEffect(path.node.left); if (leftSideEffect) { this.traverse(path); return; } if (leftEval === true && path.node.operator === '||') { // console.log('true || ___'); path.replace(path.node.left); recast.visit(path, VISITOR_METHODS); return false; } if (leftEval === true && path.node.operator === '&&') { // console.log('true && ___'); path.replace(path.node.right); recast.visit(path, VISITOR_METHODS); return false; } if (leftEval === false && path.node.operator === '&&') { // console.log('false && ___'); path.replace(path.node.left); recast.visit(path, VISITOR_METHODS); return false; } if (leftEval === false && path.node.operator === '||') { // console.log('false || ___'); path.replace(path.node.right); recast.visit(path, VISITOR_METHODS); return false; } } /** * "if" and ternary "?" */ function visitCondition(path) { var testEval = Evaluator.booleanCondition(path.node.test); if (typeof testEval !== 'boolean') { // console.log('if/? ___'); this.traverse(path); return; } var testSideEffect = Evaluator.hasSideEffect(path.node.test); if (testSideEffect) { this.traverse(path); return; } if (testEval === true) { // console.log('if/? (true)'); path.replace(path.value.consequent); recast.visit(path, VISITOR_METHODS); return false; } if (testEval === false) { // console.log('if/? (false)'); path.replace(path.value.alternate); recast.visit(path, VISITOR_METHODS); return false; } }
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 19553 | swellard | Move and rename clients | ||
//guest/perforce_software/helix-web-services/main/source/clients/2016.1.0/javascript/node_modules/unreachable-branch-transform/unreachableBranchTransformer.js | |||||
#1 | 19053 | tjuricek |
Rebuild JavaScript Client SDK. The JavaScript client now is a "typed" approach that tends to be similar in approach to the other clients, based on the swagger definition for the platform version. Importantly, client SDK tests are individual scripts (that run under node) that are actually controlled via TestNG. This approach now lets us use a consistent test reporting format so we can at least collect reports from each of the jobs. The documentation is still in progress, that I want to validate as the tests are generated. |