package org.jenkinsci.plugins.p4.review; public enum ReviewProp { STATUS("status", true), CHANGE("change", true), LABEL("label", false), // reserved by Jenkins for Slave Axes REVIEW("review", true), PASS("pass", true), FAIL("fail", true); public static final String NAMESPACE = "p4."; final private String prop; final private boolean load; ReviewProp(String prop, boolean load) { this.prop = prop; this.load = load; } public String toString() { return NAMESPACE + prop; } public String getProp() { return prop; } public boolean isLoad() { return load; } public static boolean isProp(String prop) { for (ReviewProp p : ReviewProp.values()) { if (p.isLoad() && p.getProp().equals(prop)) return true; } return false; } }
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 20641 | Paul Allen | Copy main -> dev (jenkinsci/p4-plugin) | ||
//guest/perforce_software/p4jenkins/main/src/main/java/org/jenkinsci/plugins/p4/review/ReviewProp.java | |||||
#3 | 19581 | Paul Allen | Minor fixes to satisfy FindBugs Analysis. | ||
#2 | 11492 | Paul Allen | Minor Fix: first parent builds and label namespace | ||
#1 | 10755 | Paul Allen |
Separate name space for 'label' parameter. Perforce Review endpoint added `label`, `change`, `status`, `pass`, and `fail` parameter into the environment, which is a shared name space. This clashed with the default `label` matrix name and causing users issues. The change prefixes the review parameters with `p4.` on addition to the environment. |