Rework P4Ruby unit tests so they they are actually units. Now the
test order is irrelevant as all tests are standalone. Tidied up
the code formatting as well and removed all the tabs from the ruby
sources files. Added a modeline for vim users so consistent
indentation will be used.
YAC to P4#run_tickets
Change in format to return an array of keyed hashes.
'Ticket' => 'D6EBA4584B635E19EA579E33EB0195DA',
'User' => 'pallen',
'Host' => 'localhost:2003'
Follow-on to change 500964
Forgot to submit unit test updates. Also, instead of returning nil for a directory or non-existent file, it seems more consistent to return an empty array.
Implement P4#tickets for P4Ruby
P4#tickets checks P4#ticket_file, if it's a directory or does not exist it just
returns 'nil'. Otherwise it iterates over the file and inserts each line into
an array of hashes. Each hash is a single ticket entry:
key: ticket key (hostname:port=user)
value: ticket value
Update unit test to test new functionality.
Fix unlink error on unit tests
Wrap the connect/disconnect in begin/ensure blocks to
ensure that the client disconnect even if there are failures
in a unit test.
Fix unicode unit test for 1.9. When the contents of a file
is stored in a String object, ruby 1.9 sets the String's
encoding to the current locale. This is overridden in the
test case and set to the correct value. This may need to
user visible change.
|#3||14522||tony||Add copyright notices to the test files.|
Porting changes for Windows. A few tweaks to the generated
makefile are required to stop Windows griping about
file permissions on chmod, and since it's sometimes hard
to delete a file immediately after closing it, we have
a couple of retries built-in to the test suite now.
Note that to clean up the test root, we have to shut all the
spawned p4d's down. That means all the clients must disconnect,
so the test cases that connect have all be updated to
Shuffle up the tests to make some room for one that tests setting
and getting of client environment vars.
Also give nice names to the tests while we're there.
Add P4#ticket_file and P4#ticket_file= methods to get and set the
ticket file. Note that P4#ticket_file will only return something if
a value has been previously set using P4#ticket_file=(). There's
no way, in the existing P4 API to get the current ticket file.
User-visible change to be documented in Scripting Interfaces Guide
Rename P4#input to P4#input=, and fix all pre-existing calls. The
main existing callers are p4.run_password, p4.run_submit and
and p4.run_login. There was also a bug with p4.run_password() which
meant that you couldn't change a user's password if they hadn't
already set one. Fixed that while I was there and added a test
case to check that password setting, use and clearing works.