#!/usr/bin/env python3
# -*- coding: utf-8 -*-
# ==============================================================================
# Copyright and license info is available in the LICENSE file included with
# the Server Deployment Package (SDP), and also available online:
# https://workshop.perforce.com/view/p4-sdp/main/LICENSE
# ------------------------------------------------------------------------------
# tag::includeManual[]
"""
NAME:
RequireJob.py
DESCRIPTION:
This is a trigger which allows admins to require a job to be linked with any submits.
It takes a config file of the format for Workflow.yaml which controls
whether this trigger fires or not (in addition to trigger table entries).
It refers to field 'swarm_user' and allows that user, if specified, to bypass this trigger.
Also one or more users specified by 'submit_without_review_users'.
To install, add a line to your Perforce triggers table like the following:
require-job change-submit //... "python /p4/common/bin/triggers/RequireJob.py -c /p4/common/config/Workflow.yaml -p %serverport% -u perforce %change% "
or (if server is standard SDP and has appropriate environment defaults for P4PORT and P4USER):
require-job change-submit //... "python /p4/common/bin/triggers/RequireJob.py -c /p4/common/config/Workflow.yaml %change% "
You may need to provide the full path to python executable, or edit the path to the trigger.
Also, don't forget to make the file executable.
"""
# end::includeManual[]
# Python 2.7/3.3 compatibility.
from __future__ import print_function
import sys
import WorkflowTriggers
ERROR_MSG = """
Submit failed because this codeline requires a job to be linked to every changelist!
Please retry your submit/shelve after linking a job to it.
You may need to create a P4 job from the related Jira issue.
"""
class RequireJob(WorkflowTriggers.WorkflowTrigger):
"""See module doc string for details"""
def __init__(self, *args, **kwargs):
WorkflowTriggers.WorkflowTrigger.__init__(self, **kwargs)
self.parse_args(__doc__, args)
def add_parse_args(self, parser):
"""Specific args for this trigger - also calls super class to add common trigger args"""
parser.add_argument('-c', '--config-file', default=None,
help="Configuration file for trigger. Default: RequireJob.yaml")
parser.add_argument('change', help="Change to process - %%change%% argument from triggers entry.")
super(RequireJob, self).add_parse_args(parser)
def run(self):
"""Runs trigger"""
try:
self.logger.debug("RequireJob trigger firing")
self.setupP4()
self.p4.connect()
change = self.getChange(self.options.change)
config = self.load_config(self.options.config_file)
if 'swarm_user' in config and config['swarm_user'] == change.user:
self.logger.debug("RequireJob: swarm user - no job needed")
return 0
prj = self.get_project(config, change)
self.logger.debug("prj: %s" % prj)
if not 'require_job' in prj or not prj['require_job'] == 'y':
self.logger.debug("RequireJob: no job needed")
return 0
if 'submit_without_review_users' in config:
for user in config['submit_without_review_users']:
if user == change.user:
self.logger.debug("RequireJob: user allowed to submit without job: %s" % (user))
return 0
# Look for jobs attached to this changelist
fixes = self.p4.run_fixes("-c", self.options.change)
if not fixes or len(fixes) == 0:
self.logger.debug("RequireJob: no job found")
print(ERROR_MSG)
return 1
self.logger.debug("RequireJob: job found")
return 0
except Exception:
return self.reportException()
if __name__ == '__main__':
""" Main Program"""
trigger = RequireJob(*sys.argv[1:])
sys.exit(trigger.run())
| # | Change | User | Description | Committed | |
|---|---|---|---|---|---|
| #1 | 33433 | Claude (AI Agent by Anthropic) |
Copy Up from //p4-sdp/dev into //p4-sdp/main. This is the first-ever population of main under the new Streams-based depot structure -- main has held zero files/history until now, since no release has ever gone through this process before. 463 files, covering the entire 2026.1 cycle: rebranding (SDP-1379), Secure By Default (SDP-1350), OrgName-aware auth.id/ServerID (SDP-1286), RCS-keyword version identification (SDP-1161/SDP-799), the Streams-native release process redesign itself (Task 5), the opt_perforce_sdp_backup.sh false-error fix, the P4D 2026.1 test-suite targeting, refreshed P4*.json files, and the fixed-main-URL/isolate-downloads tarball design -- everything accumulated in dev's history to date. Isolated paths (ai_dev_support/, Version, doc/*.html, doc/*.pdf, doc/gen/*.man.txt, doc/gen/sdp_install.cfg, Unsupported/doc/*.html, Unsupported/doc/*.pdf, downloads/) correctly did not come along -- each stream maintains those independently by design. Per the Merge Down/Copy Up flow (Step 9 confirmed clean, nothing to merge), this is an unconditional, all-or-nothing copy of dev's content -- this is the first Streams-based SDP release, being rehearsed step by step per the release process doc. Agent: Claude Code, Model: Claude Sonnet 5 (claude-sonnet-5), operating as bot_Claude_Anthropic. |
||
| //p4-sdp/dev/Unsupported/Samples/triggers/RequireJob.py | |||||
| #2 | 33409 | Claude (AI Agent by Anthropic) |
Copy Up from //p4-sdp/dev_rebrand into //p4-sdp/dev. This is the first promotion of dev_rebrand's work into dev since dev_rebrand was created (2025-05-24) -- 303 files, covering the entire 2026.1 rebranding effort (SDP-1379), the Secure By Default adaptation (SDP-1350), OrgName-aware auth.id/ServerID (SDP-1286), RCS-keyword version identification (SDP-1161/SDP-799), and the Streams-native release process redesign (Task 5) done this session, plus everything else accumulated in dev_rebrand's history before this session. Per the Merge Down/Copy Up flow, this is intentionally a full, unconditional blast-replace of dev's content from dev_rebrand -- all selectivity/care happened in the preceding Merge Down (dev -> dev_rebrand, changes 33407-33408), which absorbed Robert Cowham's independent dev-side work first so nothing of his is lost by this Copy Up. Two files are worth calling out since they might look alarming in isolation: - tools/mdcu.sh is deleted -- intentional, retired this session in favor of the two direct Streams commands now documented in doc/ReleaseProcessOverview.md. - tools/ReleaseProcessOverview.md is deleted -- this is a stale relic of a file move dev_rebrand made back in 2025-05-24 (tools/ -> doc/) that was never previously propagated to dev; the current, fully-rewritten doc/ReleaseProcessOverview.md is added/updated correctly by this same changelist. |
||
| #1 | 31397 | C. Thomas Tyler | Populate -b SDP_Classic_to_Streams -s //guest/perforce_software/sdp/...@31368. | ||
| //guest/perforce_software/sdp/dev/Unsupported/Samples/triggers/RequireJob.py | |||||
| #2 | 26681 | Robert Cowham |
Removing Deprecated folder - if people want it they can look at past history! All functions have been replaced with standard functionality such as built in LDAP, or default change type. Documentation added for the contents of Unsupported folder. Changes to scripts/triggers are usually to insert tags for inclusion in ASCII Doctor docs. |
||
| #1 | 26652 | Robert Cowham |
This is Tom's change: Introduced new 'Unsupported' directory to clarify that some files in the SDP are not officially supported. These files are samples for illustration, to provide examples, or are deprecated but not yet ready for removal from the package. The Maintenance and many SDP triggers have been moved under here, along with other SDP scripts and triggers. Added comments to p4_vars indicating that it should not be edited directly. Added reference to an optional site_global_vars file that, if it exists, will be sourced to provide global user settings without needing to edit p4_vars. As an exception to the refactoring, the totalusers.py Maintenance script will be moved to indicate that it is supported. Removed settings to support long-sunset P4Web from supported structure. Structure under new .../Unsupported folder is: Samples/bin Sample scripts. Samples/triggers Sample trigger scripts. Samples/triggers/tests Sample trigger script tests. Samples/broker Sample broker filter scripts. Deprecated/triggers Deprecated triggers. To Do in a subsequent change: Make corresponding doc changes. |
||
| //guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin/triggers/RequireJob.py | |||||
| #9 | 26534 | Robert Cowham | Fix specification of p4user option which was getting confused with user being checked | ||
| #8 | 24250 | Robert Cowham | Fix ordered read of yaml files and allow exceptions for RequireJob | ||
| #7 | 23665 | Robert Cowham | Allow equivalent of Jenkins users to bypass trigger too. | ||
| #6 | 23415 | Robert Cowham | Allow Swarm user to bypass trigger. | ||
| #5 | 23221 | Robert Cowham |
Test RequireJob when used with shelved changes (e.g. Swarm review) |
||
| #4 | 23195 | Robert Cowham | Update error message | ||
| #3 | 23153 | Robert Cowham | Make executable | ||
| #2 | 23152 | Robert Cowham | Refactor to push common arg_parse into P4Triggers | ||
| #1 | 23131 | Robert Cowham | New RequireJob pre-submit trigger. | ||