HI-98

rwillyoung (rwillyoung)
rwillyoung created this job , modified by swarm-user
Closed
Bogus indication that verify_sdp.sh is not available.

If '-v' is not provided, this message is displayed:

No /p4/common/bin/verify_sdp.sh script found to execute

The error message is bogus; the verify_sdp.sh is there,
but the message is displayed when the reason it is
not running verify_sdp.sh is really that the '-v'
option was not supplied.  The verify_sdp.sh script
is only supposed to execute if '-v' is specified.
28888reset_sdp.sh v4.11.3:
Fixed bogus message regarding verify_sdp.sh when '-v'
was not specified.

If the '-v' was specified, the scirpt correctly executed the
'verify_sdp.sh' script with the correct "skip test" list to
avoid errors.

However, if '-v' was not specified, a bogus message was
displayed indicating verify_sdp.sh was not available.

With this change:
* If '-v' is not specified, no output about verify_sdp.sh
is displayed at all (as was the original intent).
* If '-v' is specified and verify_sdp.sh is not avaialble,
the message disaplyed about it not being there is now
an error rahter than an informational message.

#review @rwillyoung
28887reset_sdp.sh v4.11.3:
Fixed bogus message regarding verify_sdp.sh when '-v'
was not specified.

If the '-v' was specified, the scirpt correctly executed the
'verify_sdp.sh' script with the correct "skip test" list to
avoid errors.

However, if '-v' was not specified, a bogus message was
displayed indicating verify_sdp.sh was not available.

With this change:
* If '-v' is not specified, no output about verify_sdp.sh
is displayed at all (as was the original intent).
* If '-v' is specified and verify_sdp.sh is not avaialble,
the message disaplyed about it not being there is now
an error rahter than an informational message.

#review-28888 @rwillyoung
  • Details
  • Comments -
Status
Closed
Project
perforce_software-helix-installer
Severity
C
Reported By
rwillyoung
Reported Date
Modified By
swarm-user
Modified Date
Owned By
tom_tyler
Component
core
Type
Bug