job000020
Closed
(P4HL support code) Attempts to store revs even if they can't be indexed by change.
This
creates extra bogus FileRevs with a change of "" - this only applies to changes submitted
by ancient servers (before submitted changes were numbered). In P4HL this is pretty
harmless, but it does lead to creation of extra entities. In other applications this could
lead to crashes, very hard-to-track down bugs, and me being very upset at myself when I find
out what was causing the problem.
This
creates extra bogus FileRevs with a change of "" - this only applies to changes submitted
by ancient servers (before submitted changes were numbered). In P4HL this is pretty
harmless, but it does lead to creation of extra entities. In other applications this could
lead to crashes, very hard-to-track down bugs, and me being very upset at myself when I find
out what was causing the problem.
- Status
- Closed
- Project
- p4hl
- Severity
- A
- Reported By
- Sam Stafford
- Reported Date
- Modified By
- Shawn Hladky
- Modified Date
- Owned By
- ""
- Dev Notes
- The fix should be to reject revs if change.Length() or change.Atoi() == 0.
This should go in
FileHead::addRev().