25377 | Removed journalPrefix as command line paramter during journal rotation, deferring to db.config values. Removed explicit specification of journalPrefix as a command line argument to 'p4 admin journal' and 'p4d -jj' commands. Specifying the prefix is redundant as journalPrefix values are defined for the master server and any/all replicas/edge servers in db.config, and db.config is the One Source of Truth for journalPrefix. The SDP defines best practice values for journalPrefix, with elements of this in mkrep.sh (setting configurables for replicas) and mkdirs.sh (preparing directories during initial installation). Note that verify_sdp.sh verifies that journalPrefix values are correct as per SDP standards. Also cleaned up comments. #review @mshields |
25594 | Removed journalPrefix as command line paramter during journal rotation, deferring to db.config values. Removed explicit specification of journalPrefix as a command line argument to 'p4 admin journal' and 'p4d -jj' commands. Specifying the prefix is redundant as journalPrefix values are defined for the master server and any/all replicas/edge servers in db.config, and db.config is the One Source of Truth for journalPrefix. The SDP defines best practice values for journalPrefix, with elements of this in mkrep.sh (setting configurables for replicas) and mkdirs.sh (preparing directories during initial installation). Note that verify_sdp.sh verifies that journalPrefix values are correct as per SDP standards. Also cleaned up comments. #review @mshields |
25367 | Removed journalPrefix as command line paramter during journal rotation, deferring to db.config values. Removed explicit specification of journalPrefix as a command line argument to 'p4 admin journal' and 'p4d -jj' commands. Specifying the prefix is redundant as journalPrefix values are defined for the master server and any/all replicas/edge servers in db.config, and db.config is the One Source of Truth for journalPrefix. The SDP defines best practice values for journalPrefix, with elements of this in mkrep.sh (setting configurables for replicas) and mkdirs.sh (preparing directories during initial installation). Note that verify_sdp.sh verifies that journalPrefix values are correct as per SDP standards. Also cleaned up comments. #review-25377 @mshields |