Helix SwarmHelix Swarm

About

P5 is a collection of wrappers around existing p4 commands and utilities for use with p4.
(Basically, it's stuff I wish that p4 had built-in.)
  • 1
    Member
  • 4
    Followers
  • 1
    Branch
Members
wmesard (wmesard)
Followers
matt_attaway (Matt Attaway)mike_delaney (mike_delaney)motokilljoy (moto killjoy)zachwhaley (zachwhaley)
Branches
  • Main

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
9 years agozachwhaley voted up review 12562 for main
Convert p5.html to a markdown README file

Perforce Swarm will display its contents on the p5 page.

An HTML file can be generated from the READM...E.md with any markdown parser,
i.e. redcarpet, kramdown, etc. «
5 comments
10 years agozachwhaley commented on review 12562 for main

I can't seem to commit this :(

I get an error saying "No files to commit"

Is this a permission thing?

5 comments
10 years agozachwhaley voted up review 12562 for main
Convert p5.html to a markdown README file

Perforce Swarm will display its contents on the p5 page.

An HTML file can be generated from the READM...E.md with any markdown parser,
i.e. redcarpet, kramdown, etc. «
5 comments
10 years agozachwhaley voted up review 12562 for main
Convert p5.html to a markdown README file

Perforce Swarm will display its contents on the p5 page.

An HTML file can be generated from the READM...E.md with any markdown parser,
i.e. redcarpet, kramdown, etc. «
5 comments
10 years agozachwhaley approved review 12562 for main
Convert p5.html to a markdown README file

Perforce Swarm will display its contents on the p5 page.

An HTML file can be generated from the READM...E.md with any markdown parser,
i.e. redcarpet, kramdown, etc. «
5 comments
10 years agozachwhaley updated files in review 12562 for main
Convert p5.html to a markdown README file so that Perforce Swarm will display its contents
on the p5 page.
An HTML file can be generated from the RE...ADME.md with any markdown parser, i.e. redcarpet,
kramdown, etc. «
5 comments
10 years agowmesard commented on review 12562 for main

Nit: You converted all the <li> HTML tags to numbered lists, but in fact they were bulleted lists. Other than that, LGTM.

5 comments
10 years agozachwhaley commented on review 12562 for main

Fixed tables :)

5 comments
10 years agozachwhaley updated files in review 12562 for main
Convert p5.html to a markdown README file so that Perforce Swarm will display its contents
on the p5 page.
An HTML file can be generated from the RE...ADME.md with any markdown parser, i.e. redcarpet,
kramdown, etc. «
5 comments
10 years agowmesard commented on review 12562 for main

Converting to markdown is a good idea. Thanks! It's too bad that markdown doesn't have good, standard support for tables. In this case, though, the ta

...

Converting to markdown is a good idea. Thanks! It's too bad that markdown doesn't have good, standard support for tables. In this case, though, the table format isn't really essential. I just used it because HTML has it. If you want to sidestep the issue by making some editorial changes to eliminate the tables, I'd be fine with that.

For example, you could say, "For user adent in workspace bypass3, the following pairs of commands are equivalent." And then give bulleted pairs of p5 and p4 commands.

 «
5 comments
10 years agozachwhaley commented on review 12562 for main

The tables aren't being parsed correctly. Still needs some work.

5 comments
10 years agozachwhaley updated description of review 12562 for main
Convert p5.html to a markdown README file

Perforce Swarm will display its contents on the p5 page.

An HTML file can be generated from the README.m...d with any markdown parser,
i.e. redcarpet, kramdown, etc. «
5 comments
10 years agozachwhaley requested review 12562 for main
Convert p5.html to a markdown README file so that Perforce Swarm will display its contents
on the p5 page.
An HTML file can be generated from the RE...ADME.md with any markdown parser, i.e. redcarpet,
kramdown, etc. «
5 comments
10 years agowmesard committed change 11411 into main
p5 revert's handling of abandoned files could be a little friendlier:
1. When reverting a non-existent file, don't print the inevitable
   ..."No such file or directory" error when we go and try to delete it.
2. Add a "v" option ("Delete abandoned files? (y/n/v) ") so the user
   can view which files are to be deleted before agreeing to it. «
Add a comment
10 years agowmesard committed change 10925 into main
1.
p5 share: strip "delete" lines from "p4 shelve" output.
2. Fix minor doc typo.
Add a comment
10 years agowmesard committed change 10776 into main
1.
The "p5 revert" clean up of abandoned files is best-effort.
It shouldn't abort if an unlink fails.

2. "p4 shelve" is too verbose for "p5 share"... to just echo unfiltered.
But throwing it out isn't okay either, since it may contain a useful
error message. Compromise: strip out the lines that we're expecting,
and don't care about. «
Add a comment
11 years agowmesard committed change 10129 into main
"p5 revert".
Like "p4 revert", but deletes abandoned files (files that were added,
and then reverted). By default, prompts the user before doing this.... With the "-f"
flag, doesn't prompt; just does it.

Motivation: If you leave abandoned files laying around, tools like Maven will
happily keep compiling them...until they break months later causing the build to
mysteriously fail. «
Add a comment
11 years agowmesard committed change 9969 into main
Tame the on-by-default echoing of the p4 commands being executed behind
the scenes. No one is impressed (except for me, and I can still say
"p5 -v CM...D..." to see what's going on). «
Add a comment
11 years agowmesard committed change 9963 into main
The "file..." args to restore, bdiff and bprint should support Perforce filespec syntax
("//depot", "...", "*", "@", "#").
Note: share and backup alr...eady supported it, since they already used "p4 opened" and
"p4 where" to do their thing. «
Add a comment
11 years agowmesard committed change 9687 into main
New option to p5 backup: "-d description" passes a description
for the backup rather than prompting the user (a la "p4 submit").
Note: this quietly o...bsoletes the old ill-considered "-d" flag
(which overrode the diff format used in the patch file). «
Add a comment
11 years agowmesard committed change 9657 into main
1.
New commands "p5 bdiff" and "p5 bprint" for examining files in a
   previously saved backup.
2. On a syntax error, only print the releva...nt line of the Usage message
   instead of the whole thing.
3. Be less chatty about what commands we're executing to get the job
   done ("p4 client" and "p4 opened" in particular). Anyone who really
   cares can say "p5 -v COMMAND". «
Add a comment
11 years agowmesard committed change 9610 into main
1.
If "p5 share" sees files in the default changeset, it should print
   something that looks like a changeset description summary for those...
   files. (It's too easy to have files in the default changeset
   unintentionally, so it makes sense to have p5 desc/p5 share scream
   about them.)

2. Add support for "-s" flag to "p5 share" and "p5 desc".
   (If the user says "p5 desc -s", they probably mean something
   like "p5 describe -s <all-changesets-including-default>".
   Thanks to (1), above, that now makes sense.)

3. Make "p5 resolve" honor P5_DIFF_FLAG. «
Add a comment
11 years agowmesard committed change 9604 into main
1.
Make "p5 backup" store the depot version number for each file.
   This necessitated a new backup format. So add file format versioning,
...    and a converter to read old files.
2. Make "p5 backups -l" print that version number.
3. "p4 diff -du" doesn't print the version number. It does print it for
   the other diff formats (and even for "-du3"). Since "p5 share" uses
   "p4 diff", add the version number in if necessary.
4. General code clean up. Make pylint happy. (Well...less unhappy.)
   New "File" class replaces the old list-munging code in Workspace class. «
Add a comment
11 years agowmesard committed change 9248 into main
If set in the environment, "p4 set P4USER" prints: "P4USER=useridhere"
But if it comes from .p4config, it adds garbage:   "P4USER=useridhere... (config)"
Neither "p4 -s" nor "p4 -G" seem to make it better. So we have to clean the
string ourselves. «
Add a comment
11 years agowmesard committed change 9227 into main
Update usage message.
Add a comment
11 years agowmesard committed change 9146 into main
Alternative implementations of Matt's p5 enhancements from @9100 and @9103:
1. "-u me" should honor P4USER.
2. Add a "p5 shelved" command, analogous... to "p5 pending".

# review @matt_attaway «
Add a comment
11 years agoMatt Attaway commented on review 9103 for main

Love it. Sorry I haven't replied sooner; between pair programming and meetings I haven't been up for air in a couple days. I appreciate you eradicatin

...

Love it. Sorry I haven't replied sooner; between pair programming and meetings I haven't been up for air in a couple days. I appreciate you eradicating the abomination that was my bash one-liner. 😄

 «
2 comments
11 years agowmesard commented on review 9103 for main

I like both of those enhancements a lot.
Any comments on my alternative implementation @9114?
If not, I'd like to submit that.

2 comments
11 years agoMatt Attaway requested review 9103 for main
Add a shelves command to p5

I've always wanted a shelves command, but been too lazy to do actually do it. That
ends today.

#review @wmesard
2 comments
11 years agoMatt Attaway requested review 9100 for main
Add a check for P4USER when using -me

This helps freaks like me who don't have their machine name match up with
their Perforce user name.

The imp...lementation is a bit kludgy, but I couldn't figure out a more elegant solution.

#review @wmesard «
Add a comment