Review 25359

Review requested for dev, committed in 25552
Download .zip
Add Change
Mark all comments read Mark all comments unread
Refresh projects
Fixed off-by-three-orders-of-magnitude error in Proxy cleanup script.

The key change is to adjust the output of a stat() call, dividing
the numeric value in bytes returned by 1024 to get the number of
Kilobytes.

This script makes use of the Perl stat() function, the details of
which are helpful: https://perldoc.perl.org/functions/stat.html

See also: SDP-191 and change @21751. This was an earlier change that
detected the bytes/Kilobtyes confusion, and addressed it by adjusting
the default threshhold values from the baseline version.  This change
change undoes that method of addressing the problem, rolling back to
the original defaults for thresholds.  Now with the calculation
adjusted to use KB rather than bytes, the original change is no longer
needed.

#review @amorriss
  • Files 1
  • Comments -
  • History
  • Send All Notifications
#2: Change 25552 committed into //guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin 1 0 0
p4pcm.pl#6
Loading...
Tip: Use n and p to cycle through the changes.

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs