Review 27712

Review requested for dev, tools, committed by C. Thomas Tyler in 27722
Download .zip
Add Change
Mark all comments read Mark all comments unread
Refresh projects
Pass to address spelling issues.
Most of these are just in comments or user-facing messages, but there were a couple that could impact script behavior. E.g. Server/test/test_SDP.py and Unsupported/Maintenance/sdputils.py looking at files or paths that don't exist.

Other notes..
1. I did not do anything with PDF files as I assume those are automatically generated.
2. This pass did address SDP-637, although I did it in the .adoc and .html files instead of the PDF.
3. I eventually realized Robert may have written some of these but I'd already saved the files changing things like "customisation" -> "customization" or "behaviour" -> "behavior". Sorry :(
  • Files 70
  • Comments -
  • History
  • Send All Notifications
#3: Change 27722 committed into //guest/perforce_software/sdp 70 0 0
dev/Server/Unix/p4/common/bin/backup_functions.sh#104
Loading...
dev/Server/Unix/p4/common/bin/load_checkpoint.sh#19
Loading...
dev/Server/Unix/p4/common/bin/mkrep.sh#51
Loading...
dev/Server/Unix/p4/common/bin/p4dstate.sh#7
Loading...
dev/Server/Unix/p4/common/bin/p4login#22
Loading...
dev/Server/Unix/p4/common/bin/p4master_run#9
Loading...
dev/Server/Unix/p4/common/bin/p4pcm.pl#8
Loading...
dev/Server/Unix/p4/common/bin/p4review.py#13
Loading...
dev/Server/Unix/p4/common/bin/p4review2.py#3
Loading...
dev/Server/Unix/p4/common/bin/p4verify.sh#36
Loading...
dev/Server/Unix/p4/common/bin/request_replica_checkpoint.sh#2
Loading...
dev/Server/Unix/p4/common/bin/templates/template.sh#2
Loading...
dev/Server/Unix/p4/common/bin/triggers/submit.sh#6
Loading...
dev/Server/Unix/p4/common/bin/upgrade.sh#42
Loading...
dev/Server/Unix/p4/common/bin/verify_sdp.sh#30
Loading...
dev/Server/Unix/p4/common/cloud/aws/bin/snapshot.sh#4
Loading...
dev/Server/Unix/p4/common/config/SiteTags.cfg#2
Loading...
dev/Server/Unix/p4/common/config/instance_vars.template#39
Loading...
dev/Server/Unix/p4/common/config/p4_vars.template#30
Loading...
dev/Server/Unix/p4/common/etc/cron.d/ReadMe.md#2
Loading...
dev/Server/Unix/p4/common/etc/init.d/p4dtg_instance_init.template#9
Loading...
dev/Server/Unix/p4/common/lib/libcore.sh#19
Loading...
dev/Server/Unix/p4/common/lib/p4u_env.sh#12
Loading...
dev/Server/Unix/p4/common/sdp_upgrade/clear_depot_Map_fields.sh#3
Loading...
dev/Server/Unix/setup/mkdirs.cfg#15
Loading...
dev/Server/Unix/setup/mkdirs.sh#93
Loading...
dev/Server/Windows/p4/common/bin/SDP-functions.ps1#34
Loading...
dev/Server/setup/configure_new_server.bat#40
Loading...
dev/Server/setup/configure_new_server.sh#49
Loading...
dev/Server/test/test_SDP.py#79
Loading...
dev/Unsupported/Maintenance/EvilTwinDetector.sh#3
Loading...
dev/Unsupported/Maintenance/add_users.sh#2
Loading...
dev/Unsupported/Maintenance/clean_protect.py#2
Loading...
dev/Unsupported/Maintenance/createusers.py#2
Loading...
dev/Unsupported/Maintenance/email_pending_client_deletes.py#3
Loading...
dev/Unsupported/Maintenance/license_status_check.sh#2
Loading...
dev/Unsupported/Maintenance/sdputils.py#2
Loading...
dev/Unsupported/Samples/bin/mirror_ldap_groups.cfg#2
Loading...
dev/Unsupported/Samples/bin/mirror_ldap_groups.pl#2
Loading...
dev/Unsupported/Samples/bin/mirror_ldap_groups.pl.html#2
Loading...
dev/Unsupported/Samples/bin/swarm_rename_users.py#5
Loading...
dev/Unsupported/Samples/broker/one_per_user.sh#2
Loading...
dev/Unsupported/Samples/triggers/CheckCaseTrigger.py#4
Loading...
dev/Unsupported/Samples/triggers/CheckFixes.yaml#2
Loading...
dev/Unsupported/Samples/triggers/CheckFolderStructure.py#3
Loading...
dev/Unsupported/Samples/triggers/P4Triggers.py#2
Loading...
dev/Unsupported/Samples/triggers/Workflow.yaml#2
Loading...
dev/Unsupported/Samples/triggers/WorkflowTriggers.py#2
Loading...
dev/Unsupported/Samples/triggers/externalcopy.txt#2
Loading...
dev/Unsupported/Samples/triggers/tests/TestCheckFixes.py#2
Loading...
dev/Unsupported/Samples/triggers/tests/p4testutils.py#2
Loading...
dev/Unsupported/doc/Unsupported_SDP.adoc#4
Loading...
dev/Unsupported/doc/Unsupported_SDP.html#4
Loading...
dev/Unsupported/doc/WorkflowEnforcementTriggers.adoc#2
Loading...
dev/Unsupported/doc/WorkflowEnforcementTriggers.html#2
Loading...
dev/doc/Makefile#9
Loading...
dev/doc/ReleaseNotes.adoc#27
Loading...
dev/doc/ReleaseNotes.html#21
Loading...
dev/doc/SDP_Failover_Guide.adoc#7
Loading...
dev/doc/SDP_Failover_Guide.html#9
Loading...
dev/doc/SDP_Guide.Unix.adoc#37
Loading...
dev/doc/SDP_Guide.Unix.html#37
Loading...
dev/doc/SDP_Guide.Windows.adoc#8
Loading...
dev/doc/SDP_Guide.Windows.html#11
Loading...
dev/doc/SDP_Legacy_Upgrades.Unix.adoc#19
Loading...
dev/doc/SDP_Legacy_Upgrades.Unix.html#14
Loading...
dev/helix_binaries/get_helix_binaries.sh#5
Loading...
dev/test/env.sh#6
Loading...
dev/test/run_docker_tests.sh#17
Loading...
tools/sdp_health_check.sh#17
Loading...
Tip: Use n and p to cycle through the changes.

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs