9 years agoMikeEheler committed change 19708 into Remove again unwanted files. | ||
Add a comment | ||
9 years agoMikeEheler committed change 19707 into Integrate revision 19079 from //guest/perforce_software/p4api-net/main/... into //guest/MikeEheler/p4api.net/... | ||
9 years agoMikeEheler committed change 19706 into Populate //guest/shawn_hladky/P4.Net/... //guest/MikeEheler/P4.Net/.... | ||
9 years agoMikeEheler updated files in review 15325 for perforce-software-p4api-net:main Fix corrupt p4bridge-unit-test.rc - Change filetype from utf16 to text - Rewrite file contents | ||
9 years agoMikeEheler edited reviewers on review 15325 for perforce-software-p4api-net:main Added Bill as a required reviewer. | ||
9 years agoMikeEheler commented on review 15325 (p4bridge-unit-test.rc) for perforce-software-p4api-net:main I was digging around in the source for the p4bridge unit tests and noticed that this file was corrupt. At some point before the initial commit, it mus ...I was digging around in the source for the p4bridge unit tests and noticed that this file was corrupt. At some point before the initial commit, it must have gone through a bad merge or something. The server saw funny things going on and flagged it as utf16. Really this is a cp1252 or iso-8859-1 file, like the p4bridge.rc that I based the correction on. Fortunately this is a really simple case and the fix was simply duplicating p4bridge.rc and changing the FileDescription and ProductName fields to add "Unit Tests", based on some of the recoverable content in the original file. The Microsoft compiler would have ignored this file and as a result the DLL would have had no metadata. No real loss, but might as well fix it. =] I also changed the filetype to "text". « | ||
9 years agoMikeEheler requested review 15325 for perforce-software-p4api-net:main Fix corrupt p4bridge-unit-test.rc - Change filetype from utf16 to text - Rewrite file contents | ||
9 years agoMikeEheler committed change 15315 into Merging using MikeEheler-p4api.net | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns 1 for ChangeIdBeforeSubmit. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns 1 for ChangeIdBeforeSubmit. | ||
9 years agoMikeEheler updated description of review 15310 for perforce-software-p4api-net:main Fix for Client.SubmitFiles always returning 1 for ChangeIdBeforeSubmit. | ||
9 years agoMikeEheler approved review 15305 for Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler requested further review of 15305 for Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler edited reviewers on review 15310 for perforce-software-p4api-net:main Added Bill as a required reviewer. | ||
9 years agoMikeEheler approved review 15305 for Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler edited reviewers on review 15305 for Removed Bill from the review. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler requested review 15310 for perforce-software-p4api-net:main Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler edited reviewers on review 15305 for Made Bill a required reviewer. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler edited reviewers on review 15305 for Added Bill as an optional reviewer. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler requested further review of 15305 for Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler approved review 15305 for Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler requested review 15305 for Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler committed change 15304 into Fix for Client.SubmitFiles always returning ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always sets return ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always sets return ChangeIdBeforeSubmit as 1. | ||
9 years agoMikeEheler committed change 15303 into Merging //guest/perforce_software/p4api.net/...@15207 | ||
9 years agoMikeEheler created job000329 for perforce-software-p4api-net: Submit/SubmitFiles always sets return ChangeIdBeforeSubmit as 1. | ||
10 years agoMikeEheler committed change 14777 into Removing junk files | ||
10 years agoMikeEheler committed change 14776 into Merge //guest/conous/p4api.net/p4api.net@12081 | ||
10 years agoMikeEheler committed change 14775 into Rollback //guest/MikeEheler/p4api.net/p4api.net/File.cs to revision 1 | ||
10 years agoMikeEheler committed change 14774 into Fix for issue where File.Action was always null. | ||
10 years agoMikeEheler committed change 14773 into Populate -o //guest/perforce_software/p4api.net/... //guest/MikeEheler/p4api.net/.... | ||
Change | User | Description | Created | ||
---|---|---|---|---|---|
15324 | MikeEheler | Fix corrupt p4bridge-unit-test.rc - Change filetype from utf16 to text -... Rewrite file contents « |
9 years ago | View Review |
Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).