Helix SwarmHelix Swarm
Loading...

andy_boutte

andy_boutte (Andy Boutte)
  • 0
    Followers
  • 0
    Following
  • 2
    Projects
Full Name
Andy Boutte
Email address
aboutte@perforce.com
Followers
Projects
  • Helix Installer
    • Member
  • SDP
    • Following
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
2 years agoAndy Boutte committed change 29713 into
Merging using helix-installer-dev-ami-builder
Add a comment
2 years agoAndy Boutte committed change 29712 into
Updating to latest SDP version
Add a comment
2 years agoAndy Boutte committed change 29711 into
Removing -k and adding -L
Add a comment
2 years agoAndy Boutte committed change 29710 into
Merging using helix_installer_main_to_dev_ami_builder
Add a comment
2 years agoAndy Boutte committed change 29639 into
resolving syntax issue in sudoers file
Add a comment
2 years agoAndy Boutte committed change 29636 into
Merging using helix-installer-dev-ami-builder
Add a comment
2 years agoAndy Boutte committed change 29632 into
Removing SDPVersion capabilty
Add a comment
2 years agoAndy Boutte committed change 29631 into
Matching method of curling from main branch
Add a comment
2 years agoAndy Boutte commented on review 29629 for perforce_software-helix-installer:dev

@tom can you get this merged into dev and main? Anybody who uses limited sudo mode will get locked out of sudo access.

1 comment
2 years agoAndy Boutte requested review 29629 for perforce_software-helix-installer:dev
Fixing sudoer syntax in perforce_sudoers.t template file
1 comment
2 years agoAndy Boutte committed change 29628 into perforce_software-helix-installer:dev
Fixing sudoer syntax in perforce_sudoers.t template file
Add a comment
2 years agoAndy Boutte committed change 29627 into
Setting ami_install_sdp.sh to use latest version of SDP
Add a comment
2 years agoAndy Boutte committed change 29626 into
Merging using helix_installer_main_to_dev_ami_builder
Add a comment
2 years agoAndy Boutte requested review 29539 for perforce-software-sdp:dev
Enhance p4verify to utilize die() function which will allow user to leverage AWS SNS or PagerDuty
Add a comment
2 years agoAndy Boutte edited a comment on review 29535 for perforce-software-sdp:dev

Attached screenshot of text before my changes. Note the lack of spacing after . and ,.

Example: "Thus,adding case-only..."

1 comment
2 years agoAndy Boutte commented on review 29535 for perforce-software-sdp:dev

Attached screenshot of text before my changes. Not the lack of spacing after . and ,.

Example: "Thus,adding case-only..."

1 comment
2 years agoAndy Boutte requested review 29535 for perforce-software-sdp:dev
Adding correct spacing after .
 and ,  to increase readability
1 comment
2 years agoAndy Boutte updated files in review 29512 for perforce-software-sdp:dev
Adding option to delivery log and alerts via PagerDuty
1 comment
2 years agoAndy Boutte requested review 29525 for perforce-software-sdp:dev
Adding optional local config directories for both instance and SDP wide configuration
Add a comment
2 years agoAndy Boutte commented on review 29512 for perforce-software-sdp:dev

@tom_tyler could I get this merged into dev so I can have other users start testing it?

1 comment
2 years agoAndy Boutte created SDP-897 for
Remove all uses of `-k` in curl commands
Add a comment
2 years agoAndy Boutte commented on HI-109 for

Related to https://swarm.workshop.perforce.com/projects/perforce_software-helix-installer/jobs/HI-81

1 comment
2 years agoAndy Boutte created HI-109 for perforce_software-helix-installer:
Remove all uses of `-k` in curl commands
1 comment
2 years agoAndy Boutte created SDP-896 for
Stopping and starting p4d in refresh_P4ROOT_from_offline_db.sh should be optional.


If I have a scenario where p4d is already stopped I should be ab...le to run refresh_P4ROOT_from_offline_db.sh without having to first start p4d.  For example if my online database has corruption. «
Add a comment
2 years agoAndy Boutte modified SDP-895 for
Enhance the p4d start up procedure to better handle the scenario where corruption is detected in the journal file.

The SDP can detect the corruptio...n but all it does is rotate the journal.  This leaves p4d functional but it leaves the offline database in a bad state.  The next nightly offline checkpoint will fail when attempting to replay the latest journal files to the offline database. 

I think the SDP should do one of the following:

1) The most ideal situation is if the SDP can detect the corruption to first rotate the journal but then also run live_checkppint.  This will get the offline database in a good state so that the next nightly offline checkpoint will succeed.
2) if there is no way to accomplish option #1 I think the SDP should have a configurable (opt in / opt out) to exit when corruption is detected in the journal file. «
Add a comment
2 years agoAndy Boutte created SDP-895 for
Enhance the p4d start up procedure to better handle the scenario where corruption is detected in the journal file.
Add a comment
2 years agoAndy Boutte requested review 29512 for perforce-software-sdp:dev
Adding option to delivery log and alerts via PagerDuty
1 comment
2 years agoAndy Boutte committed change 29460 into
Merging using helix-installer-dev-ami-builder
Add a comment
2 years agoAndy Boutte committed change 29459 into
Merging using helix_installer_main_to_dev_ami_builder
Add a comment
2 years agoAndy Boutte committed change 29428 into
Merging using helix-installer-dev-ami-builder
Add a comment
2 years agoAndy Boutte committed change 29427 into
adding parameter for opting into p4broker
Add a comment
2 years agoAndy Boutte commented on HI-106 for

On Ubuntu 18 the path to systemctl is /bin/systemctl

1 comment
2 years agoAndy Boutte created HI-106 for perforce_software-helix-installer:
sudoers template file needs to use variable for path to systemctl
1 comment
2 years agoAndy Boutte committed change 29351 into
Updating to latest version of helix installer and p4d
Add a comment
2 years agoAndy Boutte requested further review of 29169 for perforce_software-helix-installer:dev
Adding ubuntu 22 support into hits.sh
Add a comment
2 years agoAndy Boutte archived review 29169 for perforce_software-helix-installer:dev
Adding ubuntu 22 support into hits.sh
Add a comment
2 years agoAndy Boutte rejected review 29169 for perforce_software-helix-installer:dev
Adding ubuntu 22 support into hits.sh
Add a comment
2 years agoAndy Boutte updated files in review 29169 for perforce_software-helix-installer:dev
Reverting change used during local testing #append-29169
Add a comment
2 years agoAndy Boutte requested review 29169 for perforce_software-helix-installer:dev
Adding ubuntu 22 support into hits.sh
Add a comment
2 years agoAndy Boutte committed change 29168 into perforce_software-helix-installer:dev
Adding ubuntu 22 support into hits.sh
Add a comment
3 years agoAndy Boutte modified SDP-824 for
When Helix Core is in unicode mode CheckCaseTrigger.py will fail with the following error:

<class 'NameError'> name 'unicode' is not defined&...nbsp;

This comes from line 187 of CheckCaseTrigger.py https://swarm.workshop.perforce.com/projects/perforce-software-sdp/files/main/Unsupported/Samples/triggers/CheckCaseTrigger.py «
1 comment
3 years agoAndy Boutte modified SDP-824 for
When Helix Core is in unicode mode CheckCaseTrigger.py will fail with the following error:

<class 'NameError'> name 'unicode' is not defined&...nbsp;

This comes from line 187 of CheckCaseTrigger.py https://swarm.workshop.perforce.com/projects/perforce-software-sdp/files/main/Unsupported/Samples/triggers/CheckCaseTrigger.py «
1 comment
3 years agoAndy Boutte requested review 29028 for perforce-software-sdp:dev
SDP-824 - Update to CheckCaseTrigger to support python3 and Helix Core in unicode mode
Add a comment
3 years agoAndy Boutte commented on SDP-824 for

In Python 3 you can no longer use 'unicode' for Unicode text because all strings are now unicode.

The whole 'canonical' function can be removed but fo

...

In Python 3 you can no longer use 'unicode' for Unicode text because all strings are now unicode.

The whole 'canonical' function can be removed but for now I am testing by updating the method to be the following:

def canonical(self, aString):
    if self.p4.charset == &quot;utf8&quot;:
        return aString.lower()
    else:
        return aString.lower()
 «
1 comment
3 years agoAndy Boutte commented on review 29025 for perforce-software-sdp:dev

@tom_tyler can you take a look at this please

3 comments
3 years agoAndy Boutte requested review 29025 for perforce-software-sdp:dev
Adding in SNS notifications for failed p4 verify
3 comments
3 years agoAndy Boutte created SDP-824 for
When Helix Core is in unicode mode CheckCaseTrigger.py will fail with the following error:

<class 'NameError'> name 'unicode' is not defined&...nbsp;

This comes from line 187 of CheckCaseTrigger.py https://swarm.workshop.perforce.com/projects/perforce-software-sdp/files/main/Unsupported/Samples/triggers/CheckCaseTrigger.py «
1 comment
3 years agoAndy Boutte committed change 28984 into
merging dev into main
Add a comment
3 years agoAndy Boutte committed change 28983 into
switching to using modify if bin file already have context added
Add a comment
3 years agoAndy Boutte committed change 28982 into
Update semanage fcontext to use modify instead of add so that it is idempotent
Add a comment
Change User Description Created
29538 Andy Boutte Enhance p4verify to utilize die() function which will allow user to leverage AWS SNS or Pa...gerDuty #review-29539 « 2 years ago View Review
29534 Andy Boutte Adding correct spacing after .
 and ,  to increase readability #review-29535 		2 years ago View Review
29529 Andy Boutte local dev build of sdp for testing in packer project 2 years ago Request Review
29528 Andy Boutte local dev build of sdp for testing in packer project 2 years ago Request Review
29527 Andy Boutte local dev build of sdp for testing in packer project 2 years ago Request Review
29524 Andy Boutte Adding optional local config directories for both instance and SDP wide configuration #rev...iew-29525 « 2 years ago View Review
29511 Andy Boutte Adding option to delivery log and alerts via PagerDuty #review-29512 2 years ago View Review
29027 Andy Boutte SDP-824 - Update to CheckCaseTrigger to support python3 and Helix Core in unicode mode #re...view-29028 « 3 years ago View Review
29024 Andy Boutte Adding in SNS notifications for failed p4 verify #review-29025 3 years ago View Review
28713 Andy Boutte Correcting path to p4d_<instance> #review-28714 3 years ago View Review
28710 Andy Boutte Updating year in license #review-28711 3 years ago View Review
28706 Andy Boutte Adding firewalld template for p4p #review-28707 3 years ago View Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed