| 10 years agoBill (on behalf of MikeEheler) committed change 15334 into perforce-software-p4api-net:main Fix corrupt p4bridge-unit-test.rc
- Change filetype from utf16 to text
- Rewrite file contents | |
|
|
| 10 years agoBill approved review 15325 for perforce-software-p4api-net:main Fix corrupt p4bridge-unit-test.rc
- Change filetype from utf16 to text
- Rewrite file contents | |
|
|
| 10 years agoBill (on behalf of MikeEheler) committed change 15312 into perforce-software-p4api-net:mainFix for Client.SubmitFiles always returning 1 for ChangeIdBeforeSubmit.
bbaffy:
We should usually add a unit test, but this is a simple enough fix w...hich I have confirmed with local testing. « | |
|
|
| 10 years agoBill modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns 1 for ChangeIdBeforeSubmit. | |
|
|
| 10 years agoBill modified job000329 for perforce-software-p4api-net: Submit/SubmitFiles always returns 1 for ChangeIdBeforeSubmit. | |
|
|
| 10 years agoBill approved review 15310 for perforce-software-p4api-net:mainFix for Client.SubmitFiles always returning 1 for ChangeIdBeforeSubmit.
bbaffy:
We should usually add a unit test, but this is a simple enough fix... which I have confirmed with local testing. « | |
|
|
| 10 years agoBill approved review 12576 for perforce-software-p4api-net:main re-did the merge and submitted in 15207.
Please revert these files. They should be identical to what was submitted with 15207. | |
|
|
| 10 years agoBill addressed an issue on review 12576 for perforce-software-p4api-net:mainMaybe it would be more accurate to return a List<string> of group names that the passed user/group is a member of instead of a list of incomplet ...Maybe it would be more accurate to return a List<string> of group names that the passed user/group is a member of instead of a list of incomplete groups. I ran into this because I started trying to use the groups as if they were complete groups, but the usernames were missing. « | |
|
|
| 10 years agoBill committed change 15207 into perforce-software-p4api-net:mainMerging on behalf of cfinnie, somehow the merge in Review 12576 was showing a blank revision on the left side of the diff.
//guest/cfinnie/p4api.ne...t/main/p4api.net/...
to //guest/perforce_software/p4api.net/p4api.net/... « | |
|
|
| 10 years agoBill (on behalf of OmegaNemesis28) committed change 15203 into perforce-software-p4api-net:mainMerging
//guest/OmegaNemesis28/p4api.net/p4api.net/Options.cs
to //guest/perforce_software/p4api.net/p4api.net/Options.cs
#review
job000239 S...yncFilesCmdFlags has duplicate options.
Both Quiet and Safemode are 0x20. These flags need to be different. « | |
|
|
| 10 years agoBill approved review 13950 for perforce-software-p4api-net:mainMerging
//guest/OmegaNemesis28/p4api.net/p4api.net/Options.cs
to //guest/perforce_software/p4api.net/p4api.net/Options.cs
#review
job00023...9 SyncFilesCmdFlags has duplicate options.
Both Quiet and Safemode are 0x20. These flags need to be different. « | |
|
|
| 10 years agoBill commented on review 12576 for perforce-software-p4api-net:mainThank you for the example. It appears the underlying P4API will only return group members related to the filter that you use. I was not aware of that, ...Thank you for the example. It appears the underlying P4API will only return group members related to the filter that you use. I was not aware of that, and can see how it could be problematic.
From discussing this with my colleague, it seems that many of the spec listing commands may return incomplete individual specs this way. He suggested we do a few things to address this for Groups:
- add a GetGroupsEx that will do what you changed GetGroups to do.
- leave GetGroups as is (see note below about Group object), and better document the TaggedOutput that will be returned when using certain filters.
- add a "partial" bool to the Group object when it has not been fetched with GetGroup, and check for true and block the saves/updates of any of these potentially/likely partial specs.
So rather than revert your change to Repository.Group.cs, could you update it to retore the original GetGroups and create a new GetGroupsEx with your method?
I'll plan on getting to the other changes some time next week, unless you feel like contributing more. On that note, thanks very much for your contributions and feedback thus far! 👍 « | |
|
|
| 10 years agoBill requested revisions to review 12576 for perforce-software-p4api-net:mainThe change to Group.cs looks good.
The initial issue with Repository.Group.cs should be addressed with the TaggedOutput parsing. The tagged output f...or the p4 groups command will return users and subgroups. My tests did return UserNames for each of the 2 groups I retrieved with GetGroups. If you can provide some more details on the group and what expected fields are not being parsed, that would be helpful.
In the meantime, I will log a bug for GetGroups and investigate further on this end. We'll want to make sure we correctly parse all the information we are already getting in TaggedOutput rather than running a p4 group command for what could be a long list.
If you revert Repository.Group.cs for now, we can go ahead and accept the change to Group.cs. « | |
|
|
| 10 years agoBill committed change 12254 into perforce-software-p4api-net:main Update Workshop version with 2015.1 GA of p4api.net | |
|
|
| 10 years agoBill committed change 12078 into perforce-software-p4api-net:main add missing p4bridge\tickets.h file to the distribution. | |
|
|
| 10 years agoBill modified job000172 for perforce-software-p4api-net: Missing p4bridge\tickets.h file from the distribution.
Customer unable to build due to missing file. | |
|
|
| 10 years agoBill modified job000172 for perforce-software-p4api-net: Missing p4bridge\tickets.h file from the distribution.
Customer unable to build due to missing file. | |
|
|
| 10 years agoBill committed change 11831 into perforce-software-p4api-net:main Update Workshop version with 2014.3 GA of p4api.net | |
|
|
| 11 years agoBill committed change 9005 into perforce-software-p4api-net:main remove obsolete project reference | |
|
|
| 11 years agoBill committed change 8968 into perforce-software-p4api-net:mainAdd checks for TryParse on the change field of changelist tagged output so that a failed parse does not set the change ID to 0.
Adding related unit t...est for Repository.NewChangelist « | |
|
|
| 11 years agoBill approved review 8966 for perforce-software-p4api-net:main Duncan approved this, but was not logged into Swarm.
Approving it on his behalf. | |
|
|
| 11 years agoBill requested review 8966 for perforce-software-p4api-net:mainAdd checks for TryParse on the change field of changelist tagged output so that a failed parse does not set the change ID to 0.
Adding related unit t...est for Repository.NewChangelist « | |
|
|
| 11 years agoBill committed change 8964 into perforce-software-p4api-net:main fix line endings | |
|
|
| 11 years agoBill committed change 8938 into perforce-software-p4api-net:main changes from 2014.1/837625 PATCH | |
|
|
