11 days agoC. Thomas Tyler requested review 31401 (revision 1) for perforce-software-sdp:dev Changed SDP_VERSION setting so it is based on contents of SDP Version file. | ||
Add a comment | ||
11 days agoC. Thomas Tyler committed change 31400 into perforce-software-sdp:dev Changed SDP_VERSION setting so it is based on contents of SDP Version file. | ||
16 days agoC. Thomas Tyler committed change 31399 into Populate -r -S //p4-sdp/dev_c2s. | ||
16 days agoC. Thomas Tyler committed change 31397 into Populate -b SDP_Classic_to_Streams -s //guest/perforce_software/sdp/...@31368. | ||
19 days agoC. Thomas Tyler committed change 31395 into perforce-software-sdp:dev Added URLs and reference to P4RA. | ||
20 days agoC. Thomas Tyler committed change 31394 into perforce-software-sdp:dev Tweaked backup to incorporate hostname into the backup directory, for safety in NFS environments. | ||
20 days agoC. Thomas Tyler committed change 31394 into perforce-software-sdp:dev Tweaked backup to incorporate hostname into the backup directory, for safety in NFS environments. | ||
20 days agoC. Thomas Tyler committed change 31394 into perforce-software-sdp:dev Tweaked backup to incorporate hostname into the backup directory, for safety in NFS environments. | ||
21 days agoC. Thomas Tyler committed change 31393 into perforce-software-sdp:dev Fixed issue with too-soon removal of a temp dir. Fix to unreleased dev branch change. | ||
21 days agoC. Thomas Tyler committed change 31391 into perforce-software-sdp:dev Changed client.readonly.dir value from absolute to relative path. #review @robert_cowham @roger_prince | ||
24 days agoC. Thomas Tyler updated project (p4ms) | ||
24 days agoC. Thomas Tyler updated project (p4ms) | ||
24 days agoC. Thomas Tyler updated project (p4ms) | ||
24 days agoC. Thomas Tyler updated project (p4ms) | ||
24 days agoC. Thomas Tyler updated project (p4ms) | ||
24 days agoC. Thomas Tyler updated project (p4ms) | ||
24 days agoC. Thomas Tyler commented on the description for review 31390 for perforce-software-automerge:main Comment looks good. | ||
24 days agoC. Thomas Tyler commented on review 31388 (revision 1) (mkrep.sh, line 842) for perforce-software-sdp:dev Good call setting Preflight=OK. | ||
24 days agoC. Thomas Tyler commented on review 31388 (revision 1) (mkrep.sh) for perforce-software-sdp:dev Hey, this is a good change. | ||
26 days agoC. Thomas Tyler committed change 31385 into perforce-software-sdp:dev Fixed bug where the preflight check for journal corruption would fail if the chunk of journal scanned contained entries that referenced client.readon...ly.dir. This failure would not stop the server from starting, but would write an incorrect error in the p4d_init.log file and do an extra unneeded journal rotation. Also added logic to clean up the excess temp directory on a clean start. #review @robert_cowham « | ||
26 days agoC. Thomas Tyler committed change 31384 into perforce-software-sdp:dev Added doc to aid in migrations to SDP (e.g. for P4RA). | ||
28 days agoC. Thomas Tyler committed change 31376 into perforce-software-sdp:tools | ||
29 days agoC. Thomas Tyler committed change 31372 into perforce-software-sdp:downloads Packaged SDP 2024.2.31367. | ||
29 days agoC. Thomas Tyler committed change 31371 into perforce-software-sdp:tools Updated release process notes. | ||
29 days agoC. Thomas Tyler committed change 31369 into perforce-software-sdp:main Released SDP 2024.2.31367 (2025/03/23). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. | ||
29 days agoC. Thomas Tyler committed change 31368 into perforce-software-sdp:dev Updated Version and Release Notes. | ||
29 days agoC. Thomas Tyler committed change 31367 into perforce-software-sdp:dev Regenerated docs for release. | ||
about a month agoC. Thomas Tyler committed change 31366 into perforce-software-sdp:dev Updated generated script man pages. | ||
about a month agoC. Thomas Tyler committed change 31365 into perforce-software-sdp:dev Commented out broken test. | ||
about a month agoC. Thomas Tyler committed change 31363 into perforce-software-sdp:dev | ||
about a month agoC. Thomas Tyler committed change 31362 into perforce-software-sdp:dev Fixed issue where using mkdirs.sh to add a new instance to a machine overwrites the crontab for the first instance. Fixes SDP-1218. | ||
about a month agoC. Thomas Tyler committed change 31361 into perforce-software-sdp:dev Completed change start in @31360. | ||
about a month agoC. Thomas Tyler committed change 31360 into perforce-software-sdp:dev Enhanced and corrected docs for '-local' mode. Fixes SDP-1193. Various other doc corrections and spelling fixes, thanks to apsell. | ||
about a month agoC. Thomas Tyler committed change 31359 into perforce-software-sdp:dev Adapated fix for HI-139 into SDP-ported perforce_bashrc. Enhanced detail in comments about shopt setting. | ||
about a month agoC. Thomas Tyler committed change 31358 into perforce-software-sdp:dev | ||
about a month agoC. Thomas Tyler committed change 31357 into perforce-software-sdp:dev Refined guidance in configure_new_server.{bat,sh} to align with ccheck.sh. | ||
about a month agoC. Thomas Tyler committed change 31355 into perforce-software-sdp:dev Added '-v server=1 -v track=1' to PROXY_V_FLAGS. | ||
about a month agoC. Thomas Tyler committed change 31354 into perforce-software-sdp:dev Fixed to avoid actually loading crontab in '-test' mode. Fixes SDP-1209. | ||
about a month agoC. Thomas Tyler committed change 31353 into perforce-software-sdp:dev Removed cruft files. | ||
about a month agoC. Thomas Tyler committed change 31352 into perforce-software-sdp:tools Enhanced preview output. | ||
about a month agoC. Thomas Tyler committed change 31350 into perforce-software-sdp:dev Refine cchech.sh and config file to allow specification of 'Unset' to be required, in which case we pass the check if the value is unset regardless o...f the default value. We already allow checking the default value and consider it to comply if the default value matches expected. This new change will support some values being defined as required to be unset. Add examples and descriptive text in configurables.cfg. Fix ShellCheck compliance issues. Changed '-v' so required values having expected values show as GREAT rather than GOOD. Recommended values having expected values still show as GOOD. For values *not* matching expectations, required values show as BAD, while recommended values now show as WARN. The word FAIL is now used only in the summary, and appears only if there are any BAD indications (required values not matching) or else any system errors checking configurables. « | ||
about a month agoC. Thomas Tyler committed change 31346 into Added Windows batch shell script to push change-by-change. | ||
about a month agoC. Thomas Tyler committed change 31344 into perforce-software-sdp:dev Added default P4ALIASES for perforce OS user to SDP. | ||
about a month agoC. Thomas Tyler committed change 31341 into p4ms:main Promoted files for referencing in URLs. | ||
about a month agoC. Thomas Tyler committed change 31340 into First pass at refactoring & rebranding. | ||
about a month agoC. Thomas Tyler committed change 31339 into Bootstrapped sample files. | ||
about a month agoC. Thomas Tyler committed change 31338 into p4ms:main Bootstrap files promoted to main so the project home page link works. | ||
about a month agoC. Thomas Tyler committed change 31337 into First crack at rebranding change. WIP. | ||
about a month agoC. Thomas Tyler committed change 31336 into Bootstrapped P4MS. | ||
about a month agoC. Thomas Tyler committed change 31335 into perforce_software-hms:dev Updated Copyright to 2025. | ||
Change | User | Description | Created | ||
---|---|---|---|---|---|
31327 | C. Thomas Tyler | 2024.2 Patch 1 | 2 months ago | Request Review | |
31326 | C. Thomas Tyler | 2024.2 Patch 2. | 2 months ago | Request Review | |
31097 | C. Thomas Tyler | Fixed bug where a case-insensitive server is sensitive to the case of a server spec in th...e server.id file. If the instance is case-sensitive, then a grep for the ServerID in dumped db.server output should also be case-insensitive. An impact of this is that the run_if_*.sh scripts, e.g. run_if_edge.sh, will not work if the case of the ServerID in the $P4ROOT/server.id file doesn't match what shows in 'p4 servers'. The case must match if the data set is case- sensitive, but not if it is insensitive. Without this code change in SDP, an easy workaround for this issue is simply to make the case of the ServerID value in the server.id file match what appears in the output of 'p4 servers'. This bug may appear in a Windows to Linux migration. Fixes SDP-1184. « |
4 months ago | Request Review | |
31078 | C. Thomas Tyler | Modernized. | 4 months ago | Request Review | |
31038 | C. Thomas Tyler | Modifed scans in db.{config,server} to be case-insensitive if the data set is case-insens...itive. « |
4 months ago | Request Review | |
30842 | C. Thomas Tyler | Semantically separated DoParallelCheckpionts into two variables, CreateParallelCheckpoint... and LoadParallelCheckpoint, which are logicall independent. « |
5 months ago | Request Review | |
30781 | C. Thomas Tyler | Added files from Helix Installer pacakge into SDP. * Added firewalld templates to SDP. *... Added sudoers template. * Added bash shell templates. Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script, without any 'reset' logic. « |
11 months ago | Request Review | |
30766 | C. Thomas Tyler | Added files from Helix Installer pacakge into SDP. * Added firewalld templates to SDP. *... Added sudoers template. * Added bash shell templates. Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script, without any 'reset' logic. « |
11 months ago | Request Review | |
30713 | C. Thomas Tyler | Added files from Helix Installer pacakge into SDP. * Added firewalld templates to SDP. *... Added sudoers template. * Added bash shell templates. Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script, without any 'reset' logic. « |
11 months ago | Request Review | |
30709 | C. Thomas Tyler | Added files from Helix Installer pacakge into SDP. * Added firewalld templates to SDP. *... Added sudoers template. * Added bash shell templates. Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script, without any 'reset' logic. « |
11 months ago | Request Review | |
30690 | C. Thomas Tyler | Added files from Helix Installer pacakge into SDP. * Added firewalld templates to SDP. *... Added sudoers template. * Added bash shell templates. Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script, without any 'reset' logic. « |
11 months ago | Request Review | |
30687 | C. Thomas Tyler | Local shelf to hold shelf @30360 changes from another workspace. | 6 months ago | Request Review | |
30588 | C. Thomas Tyler | Pending shelved change. | 8 months ago | Request Review | |
30472 | C. Thomas Tyler | WIP | 9 months ago | Request Review | |
30432 | C. Thomas Tyler | Added undocumented support for /opt/perforce/helix-sdp package directory. #review-30435... With this change, mkdirs.sh behavior is changed depending on the pre-existence of the directory /opt/perforce/helix-sdp, the future package install location. The /opt/perforce/helix-sdp folder is not created by design, effectively making support for the package structure a Tech Preview (i.e. Beta) feature. This change provides behaviors needed to support package installation that also dovetail with goals of decoupling the /p4/common and /p4/sdp folders from NFS in NFS environments. If the /opt/perforce/helix-sdp is created with proper permissions and user/group ownersihp before mkdirs.sh is run, new behaviors apply. The proper ownership and permissions are: /opt/perforce/helix-sdp - root:perforce, 775 perms. Allows perforce user to manage subdirs, e.g. common, downloads, helix_binaries, p4/sdp. /opt/perforce/helix-sdp/sdp - root:root, 755 perms. This is the immutable area, an extract of the SDP tarball and no additional files. This root-managed area is intended to be updated only by OS package upgrades, and cannot be affected by the perforce user. These folders in the structure are modifiable by the perforce user (owned by perforce:perforce), and will contain generated files, symlinks, and possibly even local custom files. * /opt/perforce/helix-sdp/downloads, for unpacking SDP tarballs for upgrades. * /opt/perforce/helix-sdp/helix_binaries, contains get_helix_binaries.sh, p4*. * /opt/perforce/helix-sdp/p4/sdp - A copy of /opt/perforce/helix-sdp/sdp, owned by perforce:perforce rather than root:root. In this version, the following behaviour changes occur if /opt/perforce/helix-sdp exists when this script is run: * The /p4/sdp symlink points to /opt/perforce/helix-sdp/p4/sdp rather than /hxdepots/sdp. * The /p4/common symlink points to /opt/perforce/helix-sdp/p4/sdp/Server/Unix/p4/common rather than /hxdepots/p4/common. In this beta version, if run in an environment where those /p4/common and /p4/sdp symlinks already exist, the symlinks are NOT changed even if /opt/perforce/helix-sdp exists. This is Phase 1 if a multi-phased release of this feature. Phase 1 will support only greenfield installations where /opt/perforce/helix-sdp is created externally to this script. (Targeted for SDP 2024.1 Patch 1, July 2024) In Phase 2, the /opt/perforce/helix-sdp will be created by this script in greenfield installations with a documented '-pkg' option (if run as root), and sdp_upgrade.sh will migrate to this structure if and only if /opt/perforce/helix-sdp exists. Targeted for SDP 2024.1 Patch 2 (Summer 2024). In Phase 3, this will be integrated into the OS package installation mechanism for Rocky9+ and Ubuntu 22.04+, possibly others. (Targeted for SDP 2025.1+.) SDP-1069: Decouple /p4/common and /p4/sdp from NFS. The above captures the initial plan. See this wiki page with more updated information as it evolves: https://perforce.atlassian.net/wiki/spaces/PROS/pages/936542265/SDP-1069+Decouple+SDP+from+NFS « |
10 months ago | View Review | |
30429 | C. Thomas Tyler | Precursor to package installation support; added /opt/perforce/sdp. | 10 months ago | Request Review | |
30361 | C. Thomas Tyler | Added support for /hxhostlocal volume for string SDP files. | 11 months ago | Request Review | |
30279 | C. Thomas Tyler | Enhanced recreate_offline_db_files() to always choose latest checkpoint with...out regard to whether it is a file (serial checkpiont) or a directory (for parallel checkpoints). « |
12 months ago | Request Review | |
30253 | C. Thomas Tyler | load_checkpoint.sh v2.11.0: | about a year ago | Request Review | |
30250 | C. Thomas Tyler | wip | about a year ago | Request Review | |
30090 | C. Thomas Tyler | mkdirs.sh v5.0.0: * Added service initialization (systemd or SysV) by default if running a...s root. * Added '-no_systemd' option to not use systemd. * Added '-no_init' option to skip any/all service inititalization. * THe '-no_init' is implied with '-test' (and with undo '-R' option). * Added SELinux handling for services installed with systemd. #review-30316 @robert_cowham @mark_zinthefer @will_kreitzmann « |
about a year ago | View Review | |
30026 | C. Thomas Tyler | Enhanced upgrade.sh to better prepar for a rollback, adding docs and skipping replay of t...he rotated journal to the offline_db for the second journal rotation in a major version upgrade. #review-30027 « |
about a year ago | View Review | |
29905 | C. Thomas Tyler | Contributed changes to snapshot.sh: * Added /hxlogs to list of snapshooted volumes. * Ad...ded explicit output formatting (text) to AWS CLI calls. #review-29906 « |
about a year ago | View Review | |
29846 | C. Thomas Tyler | Enhanced sync_replica.sh and replica_status.sh to send summary rather than full email, sim...ilar to p4verify.sh. « | about a year ago | Request Review | |
29779 | C. Thomas Tyler |
Added a fix for issue with tab expansion of variables. #review-29780 |
2 years ago | View Review | |
29753 | C. Thomas Tyler |
Added SDP coding standard for bash. Enhanced format of p4_vars to improve testability. |
2 years ago | Request Review | |
29729 | C. Thomas Tyler |
Added script to detect Swarm and extract Swarm version. #review-29730 |
2 years ago | View Review | |
29625 | C. Thomas Tyler | Added script to diff local sdp install from baseline. | 2 years ago | Request Review | |
29518 | C. Thomas Tyler | Enhanced sync_replica.sh to support operation on a 'ham' type replica (HA, Metadata-only).... A 'ham' type replica replicates only metadata, and shares the /hxdepots volume (via NFS) with its target server. In this configuration, the SHAREDDATA=TRUE value is set, and this corresponds to a p4d configuration setting for the replica of lbr.replication=shared. In this configuration, the journalPrefix value of the replica server will differ from that of its target server. For example, the commit server will may have the First Form jour the journalPrefix, while an HA of the commit will have the Second Form. See 'The journalPrefix Standard': https://swarm.workshop.perforce.com/projects/perforce-software-sdp/view/main/doc/SDP_Guide.Unix.html#_the_journalprefix_standard As another example, for an edge server and HA of that edge, both servers will use the Second Form of the journalPrefix, the form which incorporates a shortened form of the ServerID into the journalPrefix value. But since the ServerIDs are different, the actual journalPrefix values will be different, even though both are of the Second Form. The common pattern is that, when configured for NFS sharing, the sync_replica.sh script should use the journalPrefix of its target server when determining where to look for a checkpoint and numbered journal to load into the offline_db. #review-29520 @mark_zinthefer @robert_cowham « |
2 years ago | View Review | |
29348 | C. Thomas Tyler | Added test for edge_vars to ensure we get the correct list of edge-specific db.* files fo...r different p4d versions. « |
2 years ago | Request Review | |
29344 | C. Thomas Tyler | Added documentation on sysconfig script. | 2 years ago | Request Review | |
29222 | C. Thomas Tyler | Take advantage of 'p4d -R' option for creating edge dumps for p4d 2022.1+. This change... is on hold pending a needed p4d server change: P4-23089/job114978 - For p4d, the '-R edge-server' option should work with '-P MyServerID'. Search the diffs for EDITME to put in the correct p4d server version after this feature is implemented. « |
2 years ago | Request Review | |
29214 | C. Thomas Tyler | Added pic files. | 2 years ago | Request Review | |
29061 | C. Thomas Tyler | added temp file for xfer. | 3 years ago | Request Review | |
28523 | C. Thomas Tyler | Added logic to determine latest major versions of Helix binaries by checking json files p...ublished at updates.perforce.com. WIP - WORK IN PROGRESS CHANGE. Shelved due to need to clean up a broken development environment. « |
3 years ago | Request Review | |
28138 | C. Thomas Tyler | Added variant of install_sdp_python.sh with no SDP dependencies, a default install locati...on of /usr/local/python, and no safety checks related to RunUser. « |
3 years ago | Request Review | |
28048 | C. Thomas Tyler | Attempted workaround for SDP-685. Changed to enhance security by ensuring copied temp s...cripts have only perms for owner from the point of inception. « |
4 years ago | Request Review | |
27938 | C. Thomas Tyler | Added '-init' option to initialize SDP on an empty data set. | 4 years ago | Request Review | |
27866 | C. Thomas Tyler | Swapped out Docker image used for Rocky Linux to the official one. | 4 years ago | Request Review | |
27446 | C. Thomas Tyler | Eliminated separate log handling in p4login. | 4 years ago | Request Review | |
27435 | C. Thomas Tyler | Added CentOS 8 to test suite. | 4 years ago | Request Review | |
27393 | C. Thomas Tyler | Added support for CentOS 8. Added support for doing a 'docker login' if a supplied .docker..._creds file existed. « |
4 years ago | Request Review | |
27004 | C. Thomas Tyler | WIP. | 4 years ago | Request Review | |
26978 | C. Thomas Tyler |
Added build.sh file in doc directory. Updated doc Makefile. |
4 years ago | Request Review | |
26954 | C. Thomas Tyler | mkdirs.sh v4.1.0: * Accounted for directory structucre change of Maintenancd to Unsupporte...d. * Added standard command line procssing with '-h' and '-man' doc flags, and other flags (all documented). * Added in-code docs and updated AsciiDoc. * Enhanced '-test' mode to simulate /hx* mounts. * Enhanced preflight testing, and fixed '-test' mode installs. * Added support for installing to an alternate root directory. * Added '-s <ServerID>' option to override REPLICA_ID. * Added '-S <TargetServerID>' used for replicas of edge servers. * Added '-t <server_type>' option to override SERVER_TYPE. * Added '-M' option to override mount points. * Added '-f' fast option to skip big chown/chmod commands, and moved those commands near the end as well. verify_sdp.sh v5.9.0: * Added check for /p4/Version file, and checked that other legacy SDP methods of checking version * Added sanity check for crontab. * Added 'test skip' mechanism to skip certain tests: - crontab - version - license - version * Added VERIFY_SDP_SKIP_TEST_LIST setting ton instance_vars.template, to define a standard way to have verify_sdp.sh always skip certain tests for a site. * Extended '-online' checks to check for bogus P4MASTERPORT, a common config error. Update test_SDP.py: * Adusted test suite to account for various changes in mkdirs.sh. * Added 'dir' parameter to run_cmd() and sudo_cmd(), to run a command from a specified directory (as required to test new mkdirs.sh) * Added check_links() similar to existing check_dirs() function. === Upgrade Process Changes === Made /p4/common/bin/p4d/p4/p4broker/p4p shell script rather than binary. This changes the way SDP new binaries are staged for upgrade. For safety, exes are now staged to a director outside the PATH, the /p4/sdp/exes foler. A new 'get_latest_exes.sh' script simplifies the task of pulling executables from the Perforce FTP server. This can be used 'as is' for environments with outbound internet access, and is useful in any case to describe now to acquire binaries. This addresses an issue where a p4d binary staged for a future upgrade might be called before the actual upgrade is performed. upgrade.sh v4.0.0: * All preflight checks are now done first. Added '-p' to abort after preflight. * Added '-n' to show what would be done before anything is executed. * Minimalist logic to start/stop only servers that are upgrade, and apply upgrades only as needed. * Staging of exes for upgrade is now separate from /p4/common/bin * Improved in-code docs, added '-h' and '-man' options. * Retained pre/post P4D 2019.1 upgrade logic. #review-26962 « |
4 years ago | View Review | |
26897 | C. Thomas Tyler |
Updated source for Python in SDP test suite for CentOS 6 and CentOS 7. #review-26902 |
4 years ago | View Review | |
26894 | C. Thomas Tyler | ALL WIP Changes. | 4 years ago | Request Review | |
26760 | C. Thomas Tyler | Enhanced is_edge() and is_standby() to avoid excess I/O. Also added internal code doc o...f sample usage. Updated calls to is_edge() and is_standby() in backup_functions.sh and edge_dump.sh. Added basic sanity test suite coverage for backup_functions.sh. # review « |
5 years ago | Request Review | |
26757 | C. Thomas Tyler | Fixed issue with load_checkpoint.sh not clearing journal.NNN file when working on a stand...by (journalcopy) replica, which prevented replication from automatically starting. These files are now moved aside. Removed undocumented edge processing logic determined to be unnecessary. Minor doc improvements. #review-26758 « |
5 years ago | View Review | |
26722 | C. Thomas Tyler | Enhanced is_edge() and is_standby() to avoid unnecessary I/O, and provided doc of sample... usage. Updated calls to is_edge() and is_standby() in backup_functions.sh and edge_dump.sh. « |
5 years ago | Request Review |
Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).