commits/13747

Change 13747

cfinnie (cfinnie)
cfinnie committed this change 10 years ago into //guest/cfinnie/p4api.net/main/p4api.net
Request Review
Download .zip
ISSUE: GetGroups when passed a Group as an argument returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Add GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.

ISSUE: Incomplete Groups retrieved by GetGroups when used to update the server would nullify group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties.
Add Job
2 edited 0 added 0 deleted
Tip: Use n and p to cycle through the changes.
norman_morse (Norman Morse)
Norman Morse commented 10 years ago

Were there no bugs associated with this change?
Reply
cfinnie (cfinnie)
cfinnie commented 10 years ago

No I didn't search for a bug. I found this while using the api. Also I'm not sure where you log bugs.
This is an update in response to bbaffy here
https://swarm.workshop.perforce.com/reviews/12576/#comments
Reply
norman_morse (Norman Morse)
Norman Morse commented 10 years ago

You can file your own bugs, go to the jobs tab for p4api.net, make sure you are logged into the workshop.
You'll see a "add a job" button.

You can expand the text area of the dialog if you need a bigger description.

Sorry to pester, but it is so nice to associate changes with jobs :)
Reply