|
|
| 10 years agocfinnie commented on review 12576 for perforce-software-p4api-net:mainI don't know what happened to break this... I can nolonger diff against the previous revision of these files from
Swarm. I tried deleting the shelf a ...I don't know what happened to break this... I can nolonger diff against the previous revision of these files from
Swarm. I tried deleting the shelf and readding the files but still no base file on the left side of the comparison. « | |
|
|
| 10 years agocfinnie commented on change 13747 forNo I didn't search for a bug. I found this while using the api. Also I'm not sure where you log bugs.
This is an update in response to bbaffy here
ht ... | |
|
|
| 10 years agocfinnie updated files in review 12576 for perforce-software-p4api-net:mainMerging
//guest/cfinnie/p4api.net/main/p4api.net/...
to //guest/perforce_software/p4api.net/p4api.net/...
ISSUE: GetGroups when passed a Group... as an argument returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Added GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: Incomplete Groups when used to update the server would nullify Group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec. « | |
|
|
| 10 years agocfinnie updated files in review 12576 for perforce-software-p4api-net:mainMerging
//guest/cfinnie/p4api.net/main/p4api.net/...
to //guest/perforce_software/p4api.net/p4api.net/...
ISSUE: GetGroups when passed a Group... as an argument returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Added GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: Incomplete Groups when used to update the server would nullify Group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec. « | |
|
|
| 10 years agocfinnie committed change 13747 intoISSUE: GetGroups when passed a Group as an argument returned a list of incomplete Group objects that did not have all their fields populated for examp...le UserNames is null for all of
the groups returned.
CHANGE: Add GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: Incomplete Groups retrieved by GetGroups when used to update the server would nullify group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties. « | |
|
|
| 10 years agocfinnie commented on review 12576 for perforce-software-p4api-net:mainThanks for the shirt! My teammate will enjoy the fabulous swag BD. I should be able to get to this later today. | |
|
|
| 10 years agocfinnie commented on review 12576 for perforce-software-p4api-net:mainHere is an example of how I was able to get null usernames for the parent groups. I am using GetGroups to get the groups that a group is a member of. | |
|
|
| 10 years agocfinnie opened an issue on review 12576 for perforce-software-p4api-net:mainMaybe it would be more accurate to return a List<string> of group names that the passed user/group is a member of instead of a list of incomplet ...Maybe it would be more accurate to return a List<string> of group names that the passed user/group is a member of instead of a list of incomplete groups. I ran into this because I started trying to use the groups as if they were complete groups, but the usernames were missing. « | |
|
|
| 10 years agocfinnie requested review 12576 for perforce-software-p4api-net:mainMerging
//guest/cfinnie/p4api.net/main/p4api.net/...
to //guest/perforce_software/p4api.net/p4api.net/...
ISSUE: GetGroups returned a list of i...ncomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Update GetGroups to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec. « | |
|
|
| 10 years agocfinnie committed change 12574 intoISSUE: GetGroups returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of the... groups returned.
CHANGE: Updated GetGroups to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec. « | |
|
|
| 10 years agocfinnie committed change 12572 into Removed unavailable bridge stress project. | |
|
|
| 10 years agocfinnie committed change 12571 into Copying
//guest/perforce_software/p4api.net/...
to //guest/cfinnie/p4api.net/main/... | |
|
|
| Change |
User |
Description |
Created |
|
|
|
12575
|
cfinnie |
Merging
//guest/cfinnie/p4api.net/main/p4api.net/...
to //guest/perforce_software/p4ap...i.net/p4api.net/...
ISSUE: GetGroups when passed a Group as an argument returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Added GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: Incomplete Groups when used to update the server would nullify Group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec.
#review-12576 « |
10 years ago
|
|
View Review
|
Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).
