Change 29590
Another refinement of sync_replica.sh logic to handle all intended use cases:
* HA of commit server, with and without NFS sharing (SHAREDDATA).
* HA of edge server, with and without NFS sharing (SHAREDDATA).
When NFS sharing, the rsync from the target server is disabled, as before.
When rsycing for full replicas (not NFS-sharing, metadata-only replicas),
the sync_replica.sh script now always rsyncs from a checkpoints directory
based on the journalPrefix of the P4TARGET server. This is correct for all
scenarios.
If that cannot be determined, the script now does a die() call to avoid
rsyncing to a possibly incorrect path.
When rebuilding the local offline_db, the checkpoints directory based on
the journalPrefix of the P4TARGET server is always used. This directory
should exist, whether due to rsync from the target, or NFS-sharing.
Logic to remove old checkpoints and journals now only cleans in folders
written to by the local replica, to avoid removing files on an NFS-shared
upstream server.
Auditability of checkpoint operations in backup_functions.sh is improved.
#review-29591
* HA of commit server, with and without NFS sharing (SHAREDDATA).
* HA of edge server, with and without NFS sharing (SHAREDDATA).
When NFS sharing, the rsync from the target server is disabled, as before.
When rsycing for full replicas (not NFS-sharing, metadata-only replicas),
the sync_replica.sh script now always rsyncs from a checkpoints directory
based on the journalPrefix of the P4TARGET server. This is correct for all
scenarios.
If that cannot be determined, the script now does a die() call to avoid
rsyncing to a possibly incorrect path.
When rebuilding the local offline_db, the checkpoints directory based on
the journalPrefix of the P4TARGET server is always used. This directory
should exist, whether due to rsync from the target, or NFS-sharing.
Logic to remove old checkpoints and journals now only cleans in folders
written to by the local replica, to avoid removing files on an NFS-shared
upstream server.
Auditability of checkpoint operations in backup_functions.sh is improved.
#review-29591