Change 33270
Fix p4lf.service: EnvironmentFile= cannot source p4_vars (a real shell script),
causing P4LOG/LOGS to never be set and the service to fail on fresh install (P4LF-3).
Replaced EnvironmentFile=-/p4/common/bin/p4_vars with an ExecStart bash -c wrapper
that actually sources p4_vars <instance> and execs the p4lf binary. This also fixes
an unrelated latent risk noted during review: the old '-' prefix on EnvironmentFile
silently ignored a missing/unreadable p4_vars file; the new wrapper aborts immediately
(non-zero exit, clear stderr message) if p4_vars is missing, instead of silently
proceeding without P4LOG/LOGS set.
causing P4LOG/LOGS to never be set and the service to fail on fresh install (P4LF-3).
Replaced EnvironmentFile=-/p4/common/bin/p4_vars with an ExecStart bash -c wrapper
that actually sources p4_vars <instance> and execs the p4lf binary. This also fixes
an unrelated latent risk noted during review: the old '-' prefix on EnvironmentFile
silently ignored a missing/unreadable p4_vars file; the new wrapper aborts immediately
(non-zero exit, clear stderr message) if p4_vars is missing, instead of silently
proceeding without P4LOG/LOGS set.