package org.jenkinsci.plugins.p4.review; public enum ReviewProp { STATUS("status"), CHANGE("change"), LABEL("label"), REVIEW("review"), PASS("pass"), FAIL("fail"); public static String NAMESPACE = "p4."; final private String prop; ReviewProp(String prop) { this.prop = prop; } public String toString() { return NAMESPACE + prop; } public String getProp() { return prop; } public static boolean isProp(String prop) { for(ReviewProp p : ReviewProp.values()) { if(p.getProp().equals(prop)) return true; } return false; } }
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 11053 | Paul Allen | Branching using p4-jenkins | ||
//guest/perforce_software/p4jenkins/main/src/main/java/org/jenkinsci/plugins/p4/review/ReviewProp.java | |||||
#1 | 10755 | Paul Allen |
Separate name space for 'label' parameter. Perforce Review endpoint added `label`, `change`, `status`, `pass`, and `fail` parameter into the environment, which is a shared name space. This clashed with the default `label` matrix name and causing users issues. The change prefixes the review parameters with `p4.` on addition to the environment. |