CheckSubmitHasReview.py #8

  • //
  • guest/
  • perforce_software/
  • sdp/
  • dev/
  • Server/
  • Unix/
  • p4/
  • common/
  • bin/
  • triggers/
  • CheckSubmitHasReview.py
  • Commits
# Change User Description Committed
#8 26652 Robert Cowham This is Tom's change:

Introduced new 'Unsupported' directory to clarify that some files
in the SDP are not officially supported. These files are samples for
illustration, to provide examples, or are deprecated but not yet
ready for removal from the package.

The Maintenance and many SDP triggers have been moved under here,
along with other SDP scripts and triggers.

Added comments to p4_vars indicating that it should not be edited
directly. Added reference to an optional site_global_vars file that,
if it exists, will be sourced to provide global user settings
without needing to edit p4_vars.

As an exception to the refactoring, the totalusers.py Maintenance
script will be moved to indicate that it is supported.

Removed settings to support long-sunset P4Web from supported structure.

Structure under new .../Unsupported folder is:
   Samples/bin             Sample scripts.
   Samples/triggers        Sample trigger scripts.
   Samples/triggers/tests  Sample trigger script tests.
   Samples/broker          Sample broker filter scripts.
   Deprecated/triggers     Deprecated triggers.

To Do in a subsequent change: Make corresponding doc changes.
#7 24624 Robert Cowham Add new feature/test for CheckSubmitHasReview:
- pre_submit_test_must_pass
When set, the Swarm testStatus config must equal 'pass'
#6 24158 Robert Cowham Refactor - tidy up triggers to make a little more consistent.
No functional change.
#5 23662 Robert Cowham Allow one or more users to bypass trigger, e.g.
jenkins user
#4 23582 Robert Cowham Fix message formatting with newlines
#3 23581 Robert Cowham Fix Swarm REST query - remove qutoe chars for \[\]
#2 23420 Robert Cowham Refactored to use common WorkflowTriggers class
#1 23418 Robert Cowham New trigger with test.
Reworked sample yaml file to Workflow.yaml