TestSwarmReviewTemplate.py #6

  • //
  • guest/
  • perforce_software/
  • sdp/
  • dev/
  • Server/
  • Unix/
  • p4/
  • common/
  • bin/
  • triggers/
  • tests/
  • TestSwarmReviewTemplate.py
  • Commits
# Change User Description Committed
#6 26652 Robert Cowham This is Tom's change:

Introduced new 'Unsupported' directory to clarify that some files
in the SDP are not officially supported. These files are samples for
illustration, to provide examples, or are deprecated but not yet
ready for removal from the package.

The Maintenance and many SDP triggers have been moved under here,
along with other SDP scripts and triggers.

Added comments to p4_vars indicating that it should not be edited
directly. Added reference to an optional site_global_vars file that,
if it exists, will be sourced to provide global user settings
without needing to edit p4_vars.

As an exception to the refactoring, the totalusers.py Maintenance
script will be moved to indicate that it is supported.

Removed settings to support long-sunset P4Web from supported structure.

Structure under new .../Unsupported folder is:
   Samples/bin             Sample scripts.
   Samples/triggers        Sample trigger scripts.
   Samples/triggers/tests  Sample trigger script tests.
   Samples/broker          Sample broker filter scripts.
   Deprecated/triggers     Deprecated triggers.

To Do in a subsequent change: Make corresponding doc changes.
#5 24985 Robert Cowham Fix problem where a review refers to a pending change which has been deleted.
We assume it has already been processed.
#4 24119 Robert Cowham Handle when required reviewers are present (and need to be removed!)
#3 23779 Robert Cowham Add new field 'swarm_review_template' to workflow.yaml and let trigger accept it.
#2 23583 Robert Cowham Handle no reviews found for a change
#1 23571 Robert Cowham New SwarmReviewTemplate trigger - shelve-commit trigger to create a Swarm review description according to a template.