job000004

samwise (Sam Stafford)
Sam Stafford created this job , modified by Shawn Hladky
Closed
Branching display is arranged oddly for some complex
integration scenarios.  At present, ordering of branches
is determined by the last point of integration rather
than by the initial branch point; further, all ancestors
of the mainline are put into place before any of the
descendants are.
981scanFrom and scanInto modified to use the "precaching" technique.
All of the tests I've run so far with this code have yielded very
comprehensible graphs, and performance is still very speedy.

This should be the final fix for job 4.
980Kludginess removed from scanMain().
 Should be a bit more
efficient now, in theory, but no real functional change (not
checking in the DLL).

Now to fix up scanFrom and scanInto....
975Nigh-complete fix for job 4 - the "scan" methods all
go from tail to head now, and Get uses the improved
"addAfter" method where appropriate.

An unforeseen problem was the fact that a complex integ
history can get followed through more than one possible
path, causing later versions of a given file to get scanned
before earlier versions, and messing up the graph.

This is fixed (albeit in a kludgey fashion) in scanMain here
by making two passes through the FileHead, caching the files
on the first pass and actually running scans on the second
pass.  A slightly more efficient way of handling it might be
to keep a list of FileRevs that need to be scanned - perhaps
by declaring a temporary FileHead to serve as a list?  Once
it's been hammered out in scanMain() satisfactorily that method
can be employed in the other scan methods.
974Partial fixes to the sorting of a FileLogCache as it's created.
  FileRevs are now doubly-linked. 
  FileHead now has a scanMain() function that acts as an interleaved
   scanFrom and scanInto.

The next step will be to have scans go from #1 to #head (this is
why FileRevs are now doubly linked).
Status
Closed
Project
p4hl
Severity
C
Reported By
Sam Stafford
Reported Date
Modified By
Shawn Hladky
Modified Date