SDP-400

tom_tyler (C. Thomas Tyler)
C. Thomas Tyler created this job , modified by C. Thomas Tyler
Closed
Fixed p4login bug where P4PORT value can have a value of Unset.
25696Fixed bug where P4PORT value might be 'Unset'.

This could be observed due to a misconfiguration where the
P4MASTER_ID value set in the instance vars file,
/p4/common/confg/p4_N.vars, was incorrect (i.e. didn't match
the actual ServerID of the master/commit server). Or if a
replica was only partially defined without P4TARGET being
defined.  These misconfigurations are outside the realm of
this script to address, but they exposed a bad assumption in
the script.  That has been corrected.

Also:
* Added logic to ensure 'p4d -cshow' is not attempted unless
$P4ROOT/db.config exists, for error-free operation on proxy and
replica servers that have no p4d.
* Several unrelated minor tweaks were made to help with shellcheck
compliance.
25769Fixed bug where P4PORT value might be 'Unset'.

This could be observed due to a misconfiguration where the
P4MASTER_ID value set in the instance vars file,
/p4/common/config/p4_N.vars, was incorrect (i.e. didn't match
the actual ServerID of the master/commit server). Or if a
replica was only partially defined without P4TARGET being
defined.  These misconfigurations are outside the realm of
this script to address, but they exposed a bad assumption in
the script.  That has been corrected.

Also:
* Added logic to ensure 'p4d -cshow' is not attempted unless
$P4ROOT/db.config exists, for error-free operation on proxy and
replica servers that have no p4d.
* Several unrelated minor tweaks were made to help with shellcheck
compliance.
25695Fixed bug where P4PORT value might be 'Unset'.

This could be observed due to a misconfiguration where the
P4MASTER_ID value set in the instance vars file,
/p4/common/confg/p4_N.vars, was incorrect (i.e. didn't match
the actual ServerID of the master/commit server). Or if a
replica was only partially defined without P4TARGET being
defined.  These misconfigurations are outside the realm of
this script to address, but they exposed a bad assumption in
the script.  That has been corrected.

Also:
* Added logic to ensure 'p4d -cshow' is not attempted unless
$P4ROOT/db.config exists, for error-free operation on proxy and
replica servers that have no p4d.
* Several unrelated minor tweaks were made to help with shellcheck
compliance.

#review-25696
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
C. Thomas Tyler
Reported Date
Modified By
C. Thomas Tyler
Modified Date
Owned By
tom_tyler
Component
core-unix
Type
Bug