SDP-713

andy_boutte (Andy Boutte)
Andy Boutte created this job , modified by swarm-user
Closed
Customizations to p4_1.vars are not preserved during sdp_upgrade.sh
28358Corrected local name of file checked for custom local logic
extraction, and corrected order of local custom config file
loading (global comes before instance-specific).

Test: Set P4_MSG="Life" at the end of p4_vars, and set
P4_MSG+=" Is Good" at the end of p4_1.vars, each below
the '### MAKE LOCAL CHANGES HERE' block.  Then echo $P4_MSG
after.
28356Corrected custom logic extraction issues found during code review/testing.
28344Added documented-but-missing logic for extracting custom logic
from SDP shell environment files.
28357Corrected local name of file checked for custom local logic
extraction, and corrected order of local custom config file
loading (global comes before instance-specific).

Test: Set P4_MSG="Life" at the end of p4_vars, and set
P4_MSG+=" Is Good" at the end of p4_1.vars, each below
the '### MAKE LOCAL CHANGES HERE' block.  Then echo $P4_MSG
after.

#review-28358
28355Corrected custom logic extraction issues found during code review/testing.

#review-28356
28343Added documented-but-missing logic for extracting custom logic
from SDP shell environment files.

#review-28344
  • Details
  • Comments -
Status
Closed
Project
perforce-software-sdp
Severity
A
Reported By
Andy Boutte
Reported Date
Modified By
swarm-user
Modified Date
Owned By
andy_boutte
Dev Notes
2021/11/17 ttyler: This is an A bug requiring a patch.
Component
core-unix
Type
Bug