SDP-855

perforce (Perforce maintenance)
Perforce maintenance created this job , modified by C. Thomas Tyler
Closed
Changes to PROXY_V_FLAGS are not persisted during upgrades.
29220Added support for parallel checkpoints in backup_function.sh.

Added doc for parallel checkpoints in new Instance Vars template.
Formal docs to be added in a future release.

Upgraded Instance Vars template to v1.5, and updated sdp_upgrade.sh accordingly.

Fixed bug where PROXY_TARGET, PROXY_PORT, and PROXY_V_FLAGS were not
preserved across SDP upgrades.

Added notes about what can and cannot be changed in the
Instance Vars template for settings to survive future upgrades.

Added notes about sourcing the SDP environment in the instance vars file.
29243Fixed issue with sdp_upgrade.sh where extraction of values with a '=' in the
value were not extracted correctly.  For example, the p4_N.vars file could
contain a value like so:

export PROXY_V_FLAGS="-v net.autotune=1"

This was parsed with:  cut -d '=' -f 2, returning incomplete text:

-v net.autotune    (sans the "=1" on the right side).

The fix was done by changing, in some places:

    cut -d '=' -f 2

with a more robust expression:

    perl -pe 's|^.*?=||g'

In some cases where the value to the right of the '=' was reliably simple, e.g.
for something like SDP_INSTANCE_VARS_FORMAT=1.5, the simpler 'cut' expression
was left in place.  The perl expression is used in places where the right-side
of the assignment could possibly be a more complex value, possibly including
an '=' sign.

Note: sed was explored, but Perl was ultimately selected as the 'sed' regular
expressions, even extended ones with '-E', do not support lazy regex macthing,
as needed for this expression.
29207Added support for parallel checkpoints in backup_function.sh.

Added doc for parallel checkpoints in new Instance Vars template.
Formal docs to be added in a future release.

Upgraded Instance Vars template to v1.5, and updated sdp_upgrade.sh accordingly.

Fixed bug where PROXY_TARGET, PROXY_PORT, and PROXY_V_FLAGS were not
preserved across SDP upgrades.

Added notes about what can and cannot be changed in the
Instance Vars template for settings to survive future upgrades.

Added notes about sourcing the SDP environment in the instance vars file.

Test suite coverage will be needed later.

#review-29220
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
Perforce maintenance
Reported Date
Modified By
C. Thomas Tyler
Modified Date
Owned By
perforce
Component
init
Type
Bug