job000215
Closed
Check for results before indexing into list.
Issue observed in 14.2 and 15.1 API.
Details:
When using P4API.NET and calling ResolveFiles on the client the following code in Client.cs keeps dying:
…
if (results.ErrorList[0].ErrorMessage.Contains("no file(s) to resolve"))
...
Since there are no errors in resolve, the results.ErrorList isn't defined and that generates a standard exception:
"object not set to an instance of an object".
The API should be checking to see if there are any errors before indexing into that array. For example:
...
if ((results.ErrorList != null) && (results.ErrorList.Count > 0) && (results.ErrorList[0].ErrorMessage.Contains("no file(s) to resolve")))
…
Issue observed in 14.2 and 15.1 API.
Details:
When using P4API.NET and calling ResolveFiles on the client the following code in Client.cs keeps dying:
…
if (results.ErrorList[0].ErrorMessage.Contains("no file(s) to resolve"))
...
Since there are no errors in resolve, the results.ErrorList isn't defined and that generates a standard exception:
"object not set to an instance of an object".
The API should be checking to see if there are any errors before indexing into that array. For example:
...
if ((results.ErrorList != null) && (results.ErrorList.Count > 0) && (results.ErrorList[0].ErrorMessage.Contains("no file(s) to resolve")))
…
- Status
- Closed
- Project
- perforce-software-p4api-net
- Severity
- B
- Reported By
- michael
- Reported Date
- 10 years ago
- Modified By
- Perforce maintenance
- Modified Date
- 6 years ago
- Owned By
- norman_morse
- Type
- Bug
Fixed in 2016.1