SDP-297

erikf (erikf)
erikf created this job , modified by C. Thomas Tyler
Closed
Fixed handling of unlaod depots in p4verify.sh

From email [tweaked]:

I found a bug related to the 'unload' depot.  It was being verified
with the wrong flags. This is because the test to identify an 'unload'
depot never succeeds.  Why?  The text returned from the extraction for
the depot type does not return 'unload' but rather '\tunload'. The sed
should be modified

From:
depot_type=`$P4 depot -o $d | sed -n "s/^Type:[     ]*\(.*\)/\1/p" `

To:
depot_type=`$P4 depot -o $d | sed -n "s/^Type:\t[     ]*\(.*\)/\1/p" `

Now p4verify is called with the -U flag for unload depot types.
23734In p4verify.sh, fixed handling of unload and spec depots.

Unload depots were not being identified correctly, and so special flags
needed for unload-type depots were not applied.

For spec-type depots, 'p4 verify -qS' was run, which isn't necessary or
helpful since it is not possible to shelve files in the spec depot.

The fix included replacing parsing logic with optimized p4 commands that
don't require parsing.
23750In p4verify.sh, fixed handling of unload and spec depots.

Unload depots were not being identified correctly, and so special flags
needed for unload-type depots were not applied.

For spec-type depots, 'p4 verify -qS' was run, which isn't necessary or
helpful since it is not possible to shelve files in the spec depot.

The fix included replacing parsing logic with optimized p4 commands that
don't require parsing.
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
erikf
Reported Date
Modified By
C. Thomas Tyler
Modified Date
Owned By
tom_tyler
Component
core-unix
Type
Bug