SDP-410

tom_tyler (C. Thomas Tyler)
C. Thomas Tyler created this job , modified by C. Thomas Tyler
Closed
[R]CMDEXITCODE not set when [r]run() called with 'grep string' parameter.
25838Fixed bug where CMDEXITCODE was not set in run() function,
and RCMDEXITCODE in rrun(), when the optional last parameter,
the 'grep string', was used.

Specifying this optional parameter changes the behavior related
to the exit code for run() and rrun() as intended.  However, the
CMDEXITCODE and RCMDEXITCODE were not being set when the 'grep string'
parameter was used.

An impact of this was that sdp_sync.sh in HMS, after a recent
change to make it shellcheck compliant, was broken, causing it
to fail to detetct 'p4 status' changes, as it relied on RCMDEXITCODE
to be set appropriately when the 'grep string' was used.

This change fixes the problem.  CMDEXITCODE is now set reliably,
even when the  'grep string' parmater is used in run().  Likewise
RCMDEXITCODE is now set reliably in rrun().
25919Fixed bug where CMDEXITCODE was not set in run() function,
and RCMDEXITCODE in rrun(), when the optional last parameter,
the 'grep string', was used.

Specifying this optional parameter changes the behavior related
to the exit code for run() and rrun() as intended.  However, the
CMDEXITCODE and RCMDEXITCODE were not being set when the 'grep string'
parameter was used.

An impact of this was that sdp_sync.sh in HMS, after a recent
change to make it shellcheck compliant, was broken, causing it
to fail to detect 'p4 status' changes, as it relied on RCMDEXITCODE
to be set appropriately when the 'grep string' was used.

This change fixes the problem.  CMDEXITCODE is now set reliably,
even when the  'grep string' paramater is used in run().  Likewise
RCMDEXITCODE is now set reliably in rrun().
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
C. Thomas Tyler
Reported Date
Modified By
C. Thomas Tyler
Modified Date
Owned By
tom_tyler
Component
core-unix
Type
Bug