SDP-428

C. Thomas Tyler
tom_tyler created this job , modified by tom_tyler
Closed
Add safety check to ensure systemd is used if required.

We want a reliable way to prevent the SysV init scripts in
the SDP from being called directly (i.e. not via systemd)
on systems where systemd is required. This includes
* RHEL/CentOS 7+,
* Ubuntu 16.04+,
* the latest Amazon Linux
* etc.

This works around a known issue with systemd:  If the old SysV
init scripts are called directly, rather than via the systemd
mechanism, then they won't be called to shutdown gracefully on
reboot.  Thus a reboot could lead to a hard kill of p4d rather
than a graceful shutdown, potentially leading to database and/or
journal corruption.
27092Refined logic so that if a shutdown is attempted and there is no
server.pid file, the 'fallback/2nd pass/assured shutdown' logic
to do a 'p4 admin stop' files only if a 'p4 info' command can
reach the server. Otherwise, the stop command is silently
ignored.

Refined exit code handling and fixed log interaciton issues.
Fixed issue with systemd status not indicating successful startup.

The systemd unit files now specify the Type as simple rather than
forking, and defer to systemd to handle the forking. When systemd is
used, the -d/--daemonsafe flags are removed from service start commands
for p4p/p4broker/p4d, and for p4dtg the & is removed so the process is
not started in the background. For compatibility with non-systemd systems,
the -d/--daemonsafe flags are still applied when systemd is not in use.

With this change, systemd's concept of whether the service is running should
now be reliable.  If you try to start without using systemd on a system for
which a systemd unit file exists, an error is displayed -- a big, hopefully
useful and informative error message.
27109Refined logic so that if a shutdown is attempted and there is no
server.pid file, the 'fallback/2nd pass/assured shutdown' logic
to do a 'p4 admin stop' files only if a 'p4 info' command can
reach the server. Otherwise, the stop command is silently
ignored.

Refined exit code handling and fixed log interaciton issues.
Fixed issue with systemd status not indicating successful startup.

The systemd unit files now specify the Type as simple rather than
forking, and defer to systemd to handle the forking. When systemd is
used, the -d/--daemonsafe flags are removed from service start commands
for p4p/p4broker/p4d, and for p4dtg the & is removed so the process is
not started in the background. For compatibility with non-systemd systems,
the -d/--daemonsafe flags are still applied when systemd is not in use.

With this change, systemd's concept of whether the service is running should
now be reliable.  If you try to start without using systemd on a system for
which a systemd unit file exists, an error is displayed -- a big, hopefully
useful and informative error message.

#review
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
tom_tyler
Reported Date
Modified By
tom_tyler
Modified Date
Owned By
tom_tyler
Component
core-unix
Type
Feature