SDP-636

Russell C. Jackson (Rusty)
russell_jackson created this job , modified by swarm-user
Closed
Get verify_sdp.sh to find bogus bins in /p4/common/bin.

For SDP 2020.1+, the "simply named" files 'p4', 'p4d',
'p4broker', and 'p4p' in /p4/common/bin must shell scripts,
not binaries.  If an SDP upgrade was done improperly,
these may be incorrect. This can be easily checked
for and reported.

See also: SDP-635.
28554Fixed issue file type detection (shell script vs. binary) did
not work on some Linux platforms, due to slightly different output
from 'file' on shell scripts on different platforms.  Type
detection logic is now more robust.

The test suite will catch this when we add support for
Rocky Linux 8.

Also corrected a copy/paste error in an error message and
enhanced code comments.

This is a bug fix to a new, not-yet-released feature.
28424verify_sdp.sh v5.21.0:

Added check that simply named files p4, p4d, p4p, and p4broker in
/p4/common/bin are indeed shell scripts, not binaries.

Also silenced configurable checks and some other checks that should
be skipped if '-skip p4root' is specified.

#review @russell_jackson
28553Fixed issue file type detection (shell script vs. binary) did
not work on some Linux platforms, due to slightly different output
from 'file' on shell scripts on different platforms.  Type
detection logic is now more robust.

The test suite will catch this when we add support for
Rocky Linux 8.

Also corrected a copy/paste error in an error message and
enhanced code comments.

This is a bug fix to a new, not-yet-released feature.

#review-28554
28423verify_sdp.sh v5.21.0:

Added check that simply named files p4, p4d, p4p, and p4broker in
/p4/common/bin are indeed shell scripts, not binaries.

Also silenced configurable checks and some other checks that should
be skipped if '-skip p4root' is specified.

#review-28424 @russell_jackson
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
russell_jackson
Reported Date
Modified By
swarm-user
Modified Date
Owned By
tom_tyler
Component
setup
Type
Feature