SDP-740

C. Thomas Tyler
tom_tyler created this job , modified by tom_tyler
Closed
sdp_upgrade.sh ignores a narrow subset of preflight checks.

The preflight/DRY RUN mode reports errors so they can be resolved
prior to an actual upgrade.  However, all preflight errors should
prevent an attempted upgrade.

This bug resulted in an erroneous message indicating "All
preflight checks were successful." if certain preflight checks
failed. This job is a 'B' is those preflight checks ignored
are considered unlikely to occur.
28570Fixed an issue where some preflight failures could be ignored, changing
return code for do_preflight_checks() from 0 to "$ErrorCount".

Also, changes in behavior to undocumented '-I' flag:

If '-I' is specified, the ErrorCount is reset to zero after preflight checks,
so we don't get a FAILURE indication if the upgrade succeeded despite ignored
warnings. This also allows custom post-processing scripts to execute upon
successful completion of an upgrade with ignored warnings.

Any new errors subsequent to preflight checks will result in a FAILURE
message.
28569Fixed an issue where some preflight failures could be ignored, changing
return code for do_preflight_checks() from 0 to "$ErrorCount".

Also, changes in behavior to undocumented '-I' flag:

If '-I' is specified, the ErrorCount is reset to zero after preflight checks,
so we don't get a FAILURE indication if the upgrade succeeded despite ignored
warnings. This also allows custom post-processing scripts to execute upon
successful completion of an upgrade with ignored warnings.

Any new errors subsequent to preflight checks will result in a FAILURE
message.

#review-28570
Status
Closed
Project
perforce-software-sdp
Severity
B
Reported By
tom_tyler
Reported Date
Modified By
tom_tyler
Modified Date
Owned By
tom_tyler
Component
core-unix
Type
Bug