About
C/C++ cross-platform build tool with a focus on providing fast builds, easy maintainability, and build analytics to allow developers to improve their build process.
- 2
Members - 1
Follower - 2
Branches
Owners
Moderators
Members
Followers
Branches
| 9 years agoShadauxCat commented on review 18284 (_gui.py, line 2531) for brandon-m-bare I may be wrong on this. But I think python 3 could just create this as b"▴ Output ▴" instead of making str and the converting to bytes. Though that ma ...I may be wrong on this. But I think python 3 could just create this as b"▴ Output ▴" instead of making str and the converting to bytes. Though that may not simplify anything here. I think we really need to make a utility function somewhere to take str input and output str in python2 and bytes in python3 instead of boilerplating this everywhere. « | ||
1 comment | ||
| 9 years agobrandon_m_bare committed change 18285 into brandon-m-bare -- Switched the manual logic of reconstructing the command line arguments to using subprocess.list2cmdline(). -- Changed the visual studio project ge...nerator to create a batch file that handles project regeneration and the (REGENERATION_SOLUTION) project just calls into that batch file. #review-17245 @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 18284 for brandon-m-bare | ||
| 9 years agobrandon_m_bare committed change 18283 into brandon-m-bare | ||
| 9 years agobrandon_m_bare requested review 17245 for brandon-m-bare -- Switched the manual logic of reconstructing the command line arguments to using subprocess.list2cmdline(). -- Changed the visual studio project ge...nerator to create a batch file that handles project regeneration and the (REGENERATION_SOLUTION) project just calls into that batch file. #review @ShadauxCat « | ||
| 9 years agoShadauxCat approved review 17242 for brandon-m-bare -- Changed the default value for the stdLib to an empty string and preventing it from being passed in the gcc toolchain unless it's explicitly set in... the makefile. -- Moved the objc abi version arg in the gcc toolchain to the extended command method and now not passing it if the input file is not an objective c/c++ file. -- Updated the README and setup.py. -- Fixed an out-of-date error message. -- Fixed a string in the gui, making it more consistent with our usage pattern for unicode strings. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 17242 for brandon-m-bare -- Changed the default value for the stdLib to an empty string and preventing it from being passed in the gcc toolchain unless it's explicitly set in... the makefile. -- Moved the objc abi version arg in the gcc toolchain to the extended command method and now not passing it if the input file is not an objective c/c++ file. -- Updated the README and setup.py. -- Fixed an out-of-date error message. -- Fixed a string in the gui, making it more consistent with our usage pattern for unicode strings. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 17241 into brandon-m-bare -- Changed the default value for the stdLib to an empty string and preventing it from being passed in the gcc toolchain unless it's explicitly set in... the makefile. -- Moved the objc abi version arg in the gcc toolchain to the extended command method and now not passing it if the input file is not an objective c/c++ file. -- Updated the README and setup.py. -- Fixed an out-of-date error message. -- Fixed a string in the gui, making it more consistent with our usage pattern for unicode strings. #review @ShadauxCat « | ||
| 9 years agoShadauxCat committed change 17221 into mainline Merging using ShadauxCat.csbuild-brandon_m_bare | ||
| 9 years agobrandon_m_bare committed change 17202 into brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review-16884 @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 17201 into brandon-m-bare | ||
| 9 years agobrandon_m_bare committed change 17200 into brandon-m-bare Fixed the issues that were causing the profile window and context menu to hang the entire gui when running pyqt5 under python3. (Submitting from a di...fferent changelist because the old one is on a computer I no longer have access to.) #review-16650 @ShadauxCat « | ||
| 9 years agobrandon_m_bare updated files in review 16884 for brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review-16884 @ShadauxCat « | ||
| 9 years agoShadauxCat approved review 16650 for brandon-m-bare Fixed the issues that were causing the profile window and context menu to hang the entire gui when running pyqt5 under python3. #review @ShadauxCa...t « | ||
| 9 years agoShadauxCat approved review 16856 for brandon-m-bare | ||
| 9 years agoShadauxCat requested revisions to review 16884 for brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review @ShadauxCat « | ||
| 9 years agoShadauxCat opened an issue on review 16884 (toolchain_gcc_darwin.py, line 288) for brandon-m-bare ...shouldn't this be "extend(libraryDirs)"? Cause this will just add each character in the library name to the list... ......and you could shortcut t ......shouldn't this be "extend(libraryDirs)"? Cause this will just add each character in the library name to the list... ......and you could shortcut that by appendLibDirs = list(libraryDirs) « | ||
| 9 years agoShadauxCat commented on review 16884 (toolchain_gcc_darwin.py, line 288) for brandon-m-bare ...shouldn't this be "extend(libraryDirs)"? Cause this will just add each character in the library name to the list... ......and you could shortcut t ......shouldn't this be "extend(libraryDirs)"? Cause this will just add each character in the library name to the list... ......and you could shortcut that by appendLibDirs = list(libraryDirs) « | ||
| 9 years agobrandon_m_bare requested review 16884 for brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16856 for brandon-m-bare | ||
| 9 years agobrandon_m_bare committed change 16824 into brandon-m-bare Fixed an exception when logging occurs outside of a decorated function in the makefile when running it with --help. #review-16822 @ShadauxCat | ||
| 9 years agoShadauxCat approved review 16822 for brandon-m-bare I have two words for this code: | ||
| 9 years agobrandon_m_bare requested review 16822 for brandon-m-bare Fixed an exception when logging occurs outside of a decorated function in the makefile when running it with --help. #review @ShadauxCat | ||
| 9 years agobrandon_m_bare requested review 16650 for brandon-m-bare Fixed the issues that were causing the profile window and context menu to hang the entire gui when running pyqt5 under python3. #review @ShadauxCa...t « | ||
| 9 years agobrandon_m_bare committed change 16635 into brandon-m-bare -- Fixed the GUI not working correctly when only warnings and errors from the linker would be present during a build. -- Fixed QtMessageBox not being... aliased for pyqt5. #review-16633 @ShadauxCat « | ||
| 9 years agoShadauxCat approved review 16633 for brandon-m-bare -- Fixed the GUI not working correctly when only warnings and errors from the linker would be present during a build. -- Fixed QtMessageBox not being... aliased for pyqt5. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16633 for brandon-m-bare -- Fixed the GUI not working correctly when only warnings and errors from the linker would be present during a build. -- Fixed QtMessageBox not being... aliased for pyqt5. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 16488 into brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review-16363 @ShadauxCat « | ||
| 9 years agoShadauxCat approved review 16363 for brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review @ShadauxCat « | ||
| 9 years agoShadauxCat commented on review 16363 (toolchain_gcc.py, line 340) for brandon-m-bare I'm not saying call it fewer times, I'm saying decrease code deduplication by having csbuild call it itself instead of repeating this same pattern ove ...I'm not saying call it fewer times, I'm saying decrease code deduplication by having csbuild call it itself instead of repeating this same pattern over and over in every toolchain. « | ||
| 9 years agoShadauxCat commented on review 16363 (toolchain_gcc.py, line 340) for brandon-m-bare This can be a future TODO, just make a card for it on the Trello. | ||
| 9 years agobrandon_m_bare commented on review 16363 (toolchain_gcc.py, line 340) for brandon-m-bare As much as I'd like to just have to call this fewer times, I don't think we can. Build settings may change between different targets or architectures ...As much as I'd like to just have to call this fewer times, I don't think we can. Build settings may change between different targets or architectures, which may be interleaved. It might be possible to do what you're talking about, but it may end up requiring architectural changes in the toolchains. « | ||
| 9 years agoShadauxCat commented on review 16363 (toolchain_gcc.py, line 340) for brandon-m-bare We should really hoist the call to setupForProject into the core logic since it keeps getting repeated so often. Actually, I take that back. All thes ...We should really hoist the call to setupForProject into the core logic since it keeps getting repeated so often. Actually, I take that back. All these setupForProject things should be toolchain postPrepareBuild steps. « | ||
| 9 years agobrandon_m_bare updated files in review 16363 for brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review-16363 @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 16367 into brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review-16307 @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16363 for brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review @ShadauxCat « | ||
| 9 years agoShadauxCat voted up review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat voted down review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat voted up review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat voted down review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat voted up review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat cleared their vote on review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat approved review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat rejected review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat requested further review of 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat requested revisions to review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agoShadauxCat approved review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16307 for brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review @ShadauxCat « | ||
| 10 years agoShadauxCat approved review 15426 for brandon-m-bare -- Disabled the caret diagnostics in the ps4 toolchain. -- Stripped the "lib" prefix from dependent library names in the ps4 toolchain. -- Fixed the... toolset name in the visual studio project generator. -- Added a new directory level to the setup script so the proprietary vsgen files get copied on install. #review @ShadauxCat « | ||
| 10 years agoShadauxCat approved review 15764 for brandon-m-bare Fixed prebuilt projects not being linked against dependencies when LinkIntermediateObjects is enabled. #review @ShadauxCat | ||