Helix SwarmHelix Swarm

riesman

riesman (riesman)
  • 0
    Followers
  • 3
    Following
  • 2
    Projects
Full Name
riesman
Email address
riesman@gmail.com
Followers
Following
lester_cheung (Lester Cheung)matt_attaway (Matt Attaway)sven_erik_knop (Sven Erik Knop)
Projects
  • SDP
    • Following
  • p4review
    • Following
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
10 years agoriesman opened an issue on review 15013 (p4review2.py, line 338) for lester-cheung-p4review:main

log.fatal was removed from the API in 3.1, use log.critical instead

2 comments
10 years agoriesman opened an issue on review 15013 (p4review2.py, line 248) for lester-cheung-p4review:main

SafeConfigParser was removed from the API in 3.2

2 comments
10 years agoriesman requested review 15013 for lester-cheung-p4review:main
Import fixes for Python3.
2 comments
10 years agoriesman commented on change 15011 for lester-cheung-p4review:main

Thanks for updating p4review. One straggler: SafeConfigParser in Python2 was folded into ConfigParser in Python3, at least since 3.3.4, the version I

...

Thanks for updating p4review. One straggler: SafeConfigParser in Python2 was folded into ConfigParser in Python3, at least since 3.3.4, the version I happen to have installed.

 «
2 comments
10 years agoriesman committed change 14024 into
Problem: the email_summary was stuck at false, even if set to true in the config file because the arg parser defaulted it to false, and command line a...rgs override the config file.
 Solution: remove default value
Problem: opening the log file in binary mode "ab" caused errors in Python 3.  Solution: open it in text mode "a".
Problem: same changes getting parsed again and again.  Solution: update review counter to last change examined. «
Add a comment
10 years agoriesman archived review 14003 for
p4review2 - Add config file parameters: debug_level, p4tickets, and p4bin.
Print message and exit if the config file is unreadable.
Fix orphaned pid... file bug in cleanup.
Include full stack trace when logging exceptions.
Test on both python 2.7 and 3.3 in Windows and fix errors.
Move imports to top of file where possible. «
Add a comment
10 years agoriesman requested review 14003 for
p4review2 - Add config file parameters: debug_level, p4tickets, and p4bin.
Print message and exit if the config file is unreadable.
Fix orphaned pid... file bug in cleanup.
Include full stack trace when logging exceptions.
Test on both python 2.7 and 3.3 in Windows and fix errors.
Move imports to top of file where possible. «
Add a comment
10 years agoriesman committed change 14001 into
p4review2 - Add config file parameters: debug_level, p4tickets, and p4bin.
Print message and exit if the config file is unreadable.
Fix orphaned pid... file bug in cleanup.
Include full stack trace when logging exceptions.
Test on both python 2.7 and 3.3 in Windows and fix errors.
Move imports to top of file where possible. «
Add a comment
10 years agoriesman committed change 14000 into
Installed p4review2 at work.
 It rocks.
2 comments
No shelved changes.

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed