Helix SwarmHelix Swarm
Loading...

sven_erik_knop

sven_erik_knop (Sven Erik Knop)
  • 11
    Followers
  • 2
    Following
  • 20
    Projects
Full Name
Sven Erik Knop
Email address
sknop@perforce.com
Followers
alan_petersen (alan_petersen)
benjamin_ma
mandrake3000 (mandrake3000)marc_wensauer (Marc Wensauer)migdur (migdur)
nellie_lemonier (Nellie Lemonier)p4fra (p4fra)phopkins (phopkins)riesman (riesman)stefan_callsen (stefan_callsen)
tom_tyler (C. Thomas Tyler)
Following
paul_allen (Paul Allen)perforce_software (perforce_software)
Projects
  • P4Docker
    • Owner, Member
  • P4Transfer
    • Owner, Member
  • CBD
    • Member
  • JournalReader
    • Member
  • P4Perl
    • Member
  • P4Python
    • Member
  • P4PythonLib
    • Member
  • P4_Search
    • Member
  • perl-sdk
    • Member
  • P4
    • Following
  • P4Convert
    • Following
  • P4DTG-SDK
    • Following
  • P4Java
    • Following
  • P4Jenkins
    • Following
  • P4Web
    • Following
  • P4Win
    • Following
  • SDP
    • Following
  • VTFS2P4
    • Following
  • Workshop
    • Following
  • p4review
    • Following
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
7 years agoSven Erik Knop committed change 23700 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Completed test cases for Stream Transfer, including rename.

Good to go, no further changes required from my point of view.
Add a comment
7 years agoSven Erik Knop committed change 23699 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Always create test cases.
Found a couple of nasty bugs already.

Direct and indirect transfers are tested and seem to work fine. I am going to add a f...ew more tests,
specifically but not exclusive to renames. «
Add a comment
7 years agoSven Erik Knop committed change 23692 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Simple trigger that logs sizes of submitted changelists.

Invoke with

python3 SizeLogger.py <config> <change>

where config is the fil...ename of a config file containing the following two sections:
--------------
[P4]
port=1666
user=tom
password=A154ABF11F094B5D288CA0BE9F6F1086

[Log]
logfile=mylogfile.log
--------------

The P4 connection will use the standard defaults for any parameters not defined (such P4PORT, P4USER)
The default log file is called 'sizes.log'

Since this trigger is based on the standard P4Triggers.py, it will also create a separate log file (p4triggers.log) for any errors
that occur from a connection failure or other exception thrown.

Install this trigger like this in the triggers table:

   SizeLogger change-commit   //depot/path/... "python3 SizeLogger.py configfile.name %change%"

You need to have P4Triggers.py in the same path as the SizeLogger.py file.

---------

This trigger uses 'p4 describe' to collect all files in the change, filters out any files that do not have 'add' or 'edit' action, and
then sums up the remaining file sizes - so branches and renames are ignored.
The output in the log file is in JSON format for easy parsing.

---------

I also updated P4Triggers.py to add size and digest to the internal stored change «
Add a comment
7 years agoSven Erik Knop committed change 23630 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Beginning of a GUI tool to check and set configurables.
Add a comment
7 years agoSven Erik Knop committed change 23623 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Updated to enable renaming of target streams
Add a comment
7 years agoSven Erik Knop committed change 23587 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Renamed to Transfer
Add a comment
7 years agoSven Erik Knop committed change 23586 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Little tool to transfer stream hierarchies
Add a comment
7 years agoSven Erik Knop committed change 23584 into perforce_software-p4python:main
Updated P4Python to 2017.2 in sync with the internal development version.
Add a comment
7 years agoSven Erik Knop committed change 23552 into journalreader:main, stuff-tom-follows:multiuserfollow
Fixed indentation, no functional change
Add a comment
7 years agoSven Erik Knop committed change 23518 into journalreader:main, stuff-tom-follows:multiuserfollow
Upgrade the Tokenizer to deal with Base64 encoded numbers.
Add a comment
7 years agoSven Erik Knop committed change 23517 into journalreader:main, stuff-tom-follows:multiuserfollow
Added table bodresolve
Add a comment
7 years agoSven Erik Knop committed change 23494 into journalreader:main, stuff-tom-follows:multiuserfollow
Updated schema (partitially) to 2017.2

Still missing:

graph depot schemas
some rp (edge server) schemas
Add a comment
7 years agoSven Erik Knop committed change 23489 into journalreader:main, stuff-tom-follows:multiuserfollow
Fix map remove call to avoid compile error.
Add a comment
7 years agoSven Erik Knop committed change 23208 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Use decorator to surround tests for simplication.
Add a comment
7 years agoSven Erik Knop committed change 23188 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Add another two test cases that are expected to fail for now.

Need to rethink how these issues can be addressed, might need an additional check.
Add a comment
7 years agoSven Erik Knop committed change 23177 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Removed all old P4Python executables.

pip install p4python has superceeded the old way of installing P4Python on Windows.
We also publish the execut...ables on the ftp site now, so there is no need to keep these
releases around anymore. «
Add a comment
7 years agoSven Erik Knop committed change 23176 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
New test case checking the exception itself.
Add a comment
7 years agoSven Erik Knop committed change 23175 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Additional test case checking multiple directories in the same change.
Add a comment
7 years agoSven Erik Knop committed change 23174 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
New test case verifying that a conflict in the same change is caught.
Add a comment
7 years agoSven Erik Knop committed change 23173 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Fixed one problem - move/add now recognised
Add a comment
7 years agoSven Erik Knop committed change 23172 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Added two test cases expected to fail for now:

Renaming a file to a filename conflicting with an existing file.
Creating a directory that conflicts... with an existing file with different spelling. «
Add a comment
7 years agoSven Erik Knop committed change 23171 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Added simple directory fail test
Add a comment
7 years agoSven Erik Knop committed change 23169 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Added test for foo != FOO/bar
Add a comment
7 years agoSven Erik Knop committed change 23168 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Simple test to proof that the basic premise of the CheckCaseTrigger works.
Add a comment
7 years agoSven Erik Knop committed change 23167 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Fix bug where a keyword argument contained '=' itself.

The trigger accepts keyword arguments in the form key=value, for example
port=server:1666

... In the test case, I am passing in port as "rsh:p4d -r /path/to/root -vserver=3 -i", which
gets split into three and not two strings. Fortunately, Python's string.split() has an optional
argument limiting the number of splits. «
Add a comment
7 years agoSven Erik Knop committed change 23154 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Adding further test cases.
Testing can only be done on Linux (case sensitive file system)
Add a comment
7 years agoSven Erik Knop committed change 23145 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
example for client default trigger
Add a comment
7 years agoSven Erik Knop committed change 23144 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Beginning of TestCase for CheckCaseTrigger
Add a comment
7 years agoSven Erik Knop committed change 23022 into perforce-software-sdp:dev
Simple fix for daily_checkpoint if the master server has its own server spec.
2 comments
7 years agoSven Erik Knop created SDP-257 for
Add enabling of Unicode to documentation and scripts
Add a comment
7 years agoSven Erik Knop created SDP-256 for
Update documentation to include mkdirs.cfg instead of updating mkdirs.sh
Add a comment
7 years agoSven Erik Knop created SDP-255 for
Update SDP documentation to deal with SSL enabled servers.

Location of P4Trust file
Order of steps to run through
Verification of scripts to ensure... they are running correctly «
1 comment
8 years agoSven Erik Knop committed change 22579 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Updated copyright notice
Add a comment
8 years agoSven Erik Knop committed change 22578 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Little example tool to identify which changes have been completely integrated via copy.
   The tool will collect the respective change descr...iptions and append them to the existing change description.
   Note that this script only prints out the resulting change description. A trigger might run 'p4 change -f' to
   update the integration description. «
Add a comment
8 years agoSven Erik Knop committed change 22484 into perforce_software-p4python:main
Added missing release notes and resurrected README.md
Add a comment
8 years agoSven Erik Knop committed change 22483 into perforce_software-p4python:main
Updated to 2017.1
Add a comment
8 years agoSven Erik Knop commented on review 22422 (setup.py, line 566) for perforce_software-p4python:main

Thank you for your contribution. I have fixed this in the master source using this string

"OpenSSL (\d).(\d).(\d)(\S+)\s+\d+ \S+ \d+"

Would that be a

...

Thank you for your contribution. I have fixed this in the master source using this string

"OpenSSL (\d).(\d).(\d)(\S+)\s+\d+ \S+ \d+"

Would that be acceptable? I didn't want to get caught out by yet another prefix, and I am only really interested in the first few numbers.

 «
2 comments
8 years agoSven Erik Knop modified job000366 for perforce_software-p4python:
Support DVCS functionality

It would be nice to be able to clone and init from scripts.

Implemented in 2015.1
Add a comment
8 years agoSven Erik Knop committed change 21879 into stuff-tom-follows:multiuserfollow
Update IP address to match my standards
Add a comment
8 years agoSven Erik Knop committed change 21706 into stuff-tom-follows:multiuserfollow
Populate //cbd/main/...
....
Add a comment
8 years agoSven Erik Knop committed change 21667 into perforce_software-p4python:main
Update OpenSource version of P4Python to 2016.2

   This source drop is virtually identical to the internal release.
   The sourc...e is also available from pypi as a tar ball, here for completeness
   and to encourage anyone who wants to extend or fix P4Python. «
Add a comment
8 years agoSven Erik Knop committed change 21666 into perforce_software-p4python:main
You don't belong here.
1 comment
8 years agoSven Erik Knop committed change 21316 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Enhanced error output to print the actual exception.

Should make debugging a bit easier.
Add a comment
8 years agoSven Erik Knop committed change 21258 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Fixed crashing on changes that have no add or branches.

Improved reporting.
Add a comment
8 years agoSven Erik Knop committed change 21202 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Completed the trigger for now, subject to unit tests

This trigger is supposed to prevent a submit of a new file (or a branch)
that would create a co...nflict between a filename and a directory name.
In Perforce, it is currently possible to submit a filename that exists already
as a directory name, because the server does not recognise directory names as
independent entities. When this happens, clients cannot sync files anymore from the path: files and directories cannot live in the same file system with the same name.

This trigger will analyse a submit (as a change-submit trigger *only*):

- extract all "add" and "branch" operations
- extract all unique directories out of the above list
- extract all file names out the above list

- check that there is no file already submitted that matches the directories
- check that there is no directory already submitted that matches the files

This trigger will run 3 Perforce queries: extract the change, list matching files and list matching directories.
This trigger should run as a user who has list permissions for all possible files under the path specified in the trigger table. The user needs to have a permanent ticket available on the server for the trigger to run.

Output is a list of all violating files:



    Your submission has been rejected because the following files
    or directories already exist as a directory or file.


    Your file:         //depot/file1 «
Add a comment
8 years agoSven Erik Knop committed change 21201 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Now with case-sensitive protection
Add a comment
8 years agoSven Erik Knop committed change 21200 into p4pythonlib:p4pythonlib, stuff-tom-follows:multiuserfollow
Beginning of FileDirectoryProtector.

This trigger is supposed to protect from the situation where a user submits a
file that has the same name as a... directory. The Perforce server cannot detect
this, causing all kinds of problems along the line.

Step one: break a submit down into its directories and files. «
Add a comment
8 years agoSven Erik Knop committed change 20945 into stuff-tom-follows:multiuserfollow
Release builds instead of debug builds.
Separate DLL for 32 bit and 64 bit

Requires VCS10 redistribution libraries installed to work.
Add a comment
8 years agoSven Erik Knop committed change 20943 into stuff-tom-follows:multiuserfollow
Re-submit to figure out why this version does not work on Windows 10.
Add a comment
9 years agoSven Erik Knop committed change 20225 into perforce_software-p4python:main
Updated P4Python to released version of 2016.1
Add a comment
Change User Description Created
23207 Sven Erik Knop Whatever happened here? 7 years ago Request Review
8427 Sven Erik Knop Additional backup functions 12 years ago Request Review
8177 Sven Erik Knop Update to P4PyReview

plumbing in the actual reviewing of changes 		13 years ago Request Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed