Loading...
Helix SwarmHelix Swarm
Loading...

Change 10089

lester_cheung (Lester Cheung)
Lester Cheung modified this change 11 years ago into //guest/perforce_software/p4web under Review 10411
View Review
Download .zip
Using HTTPS for favicon when option -ss (HTTPS mode) is used.
#review-10411
0 comments Log in to comment
job000053URL for favicon is hardcoded to HTTP.
... even when running in HTTPS (-ss) mode.... «
Add Job
  • Files 6
  • Comments 1
6 edited 0 added 0 deleted
Views/p4wAuthView.cpp
Loading...
Views/p4wLogoutStartView.cpp
Loading...
Views/p4wLogoutView.cpp
Loading...
Views/p4wView.cpp
Loading...
util/p4wHtml.cpp
Loading...
util/p4wHtml.h
Loading...
Tip: Use n and p to cycle through the changes.
0 archived comments
matt_attaway (Matt Attaway)
  • Flag as Task
if (faviconhttp)
{
- *this << "<link rel=\"shortcut icon\" href=\"http://";
- *this << faviconhttp;
+ *this << "<link rel=\"shortcut icon\" href=\"";
Matt Attaway (on p4wHtml.cpp, line 1215) commented 11 years ago

I think we still need to add "faviconhttp" to the URL like in line 1216 in the original. I guess we'll require the 'http|s' as part of the admin set favicon path.
Reply ·0
Log in to comment