Change 12575
Merging
//guest/cfinnie/p4api.net/main/p4api.net/...
to //guest/perforce_software/p4api.net/p4api.net/...
ISSUE: GetGroups when passed a Group as an argument returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Added GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: Incomplete Groups when used to update the server would nullify Group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec.
#review-12576
//guest/cfinnie/p4api.net/main/p4api.net/...
to //guest/perforce_software/p4api.net/p4api.net/...
ISSUE: GetGroups when passed a Group as an argument returned a list of incomplete Group objects that did not have all their fields populated for example UserNames is null for all of
the groups returned.
CHANGE: Added GetGroupsEx to use GetGroup to populate the Group list since it sets all properties of the object.
ISSUE: Incomplete Groups when used to update the server would nullify Group properties on the server
CHANGE: Added boolean IsUpdateSafe property to Group class that will be true when a Group is constructed with all of its properties and false when constructed with only the Id and default null properties.
ISSUE: GetGroup would return a Group object missing the SubGroups because of an access with a key that was incorrectly cased. If the returned Group is used to update the repository, SubGroup members are removed.
CHANGE: Updated case of SubGroup key to Subgroup to match Group Spec.
#review-12576
0 comments
Log in to comment