Change 15873
Added automatic calls to trust remote servers, if enabled in the system.
It's enabled by default, but can be disabled for admins that do not want it.
The p4trust file is moved somewhere writable by us.
Also, disabling the p4enviro cache.
It's enabled by default, but can be disabled for admins that do not want it.
The p4trust file is moved somewhere writable by us.
Also, disabling the p4enviro cache.
0 comments
Log in to comment
Tip: Use n and p to cycle through the changes.
|
|
+ # Look for trust failure + if p4.messages && + p4.messages.any? { |m| m.msgid == 3120 } && + HWSSettings.system.ENABLE_AUTOMATIC_TRUST == true + p4.run_trust('-y', '-f')
gnicol (on auth.rb, line 109) commented
9 years ago
You very much shouldn't include -f here. A number of our systems have auto-trust behaviour (Swarm and GitSwarm for example) and it seems to be received well. The logic however is always to trust if you've never seen it before (trust -y) its quite intentionally not to always trust all the things (trust -y -f). The latter scenario basically invalidates the MITM protection normally provided by SSL p4 connections and is not a good idea. |
| ·0 | |
|
|
|
|
|
+ # Look for trust failure + if p4.messages && + p4.messages.any? { |m| m.msgid == 3120 } && + HWSSettings.system.ENABLE_AUTOMATIC_TRUST == true + p4.run_trust('-y', '-f')
tjuricek (on auth.rb, line 109) commented
9 years ago
Ah ha, I was wondering about that. Easy enough to change. |
| ·0 | |
|
|
|
|
|
+ # Look for trust failure + if p4.messages && + p4.messages.any? { |m| m.msgid == 3120 } && + HWSSettings.system.ENABLE_AUTOMATIC_TRUST == true + p4.run_trust('-y', '-f')
gnicol (on auth.rb, line 109) commented
9 years ago
Cool; thanks for being receptive to the feedback! |
| ·0 | |
|
|
|
|
|
+ # Look for trust failure + if p4.messages && + p4.messages.any? { |m| m.msgid == 3120 } && + HWSSettings.system.ENABLE_AUTOMATIC_TRUST == true + p4.run_trust('-y', '-f')
tjuricek (on auth.rb, line 109) commented
9 years ago
Thanks for reviewing things without me asking :) |
| ·0 | |
|
|