|
+ if p4.messages && !p4.messages.empty? && p4.messages.first.msgid == 7481 + p4.password = '' + else + p4.password = results[0] + end
gnicol (on auth.rb, line 151) commented
9 years ago
Tristan, in swarm (to be more technically correct) we reject loging in with a password if no password is required. i.e. an attempt to auth as gnicol with 'password-guess' will fail if gnicol has no password. https://swarm.perforce.com/projects/swarm/files/main/library/P4/Connection/AbstractConnection.php#612 I'd suggest the HWS would behave more sanely if it shared this approach. |
Reply ·0 | |
|
|
|
+ if p4.messages && !p4.messages.empty? && p4.messages.first.msgid == 7481 + p4.password = '' + else + p4.password = results[0] + end
tjuricek (on auth.rb, line 151) commented
9 years ago
This change is mostly meant to for clients to avoid workflow changes when the server has security 0 and no password. The empty "ticket" can be used as the user's valid password. It's odd, I agree, and I don't like the fact the server allows this. But, it would add more complexity to the clients. I've requested that we block no passwords across the board too, and that didn't fly. If you really, really want it changed, I'd need to run it past Alan again, since this was behavior he wanted. |
Reply ·0 | |
|
|
|
+ if p4.messages && !p4.messages.empty? && p4.messages.first.msgid == 7481 + p4.password = '' + else + p4.password = results[0] + end
gnicol (on auth.rb, line 151) commented
9 years ago
Given you're consistent with P4D's behaviour I wouldn't push too hard on it. I think allowing an invalid password for an account with no password is poor form though and given how long its been like that I can't imagine p4d can fix it (though our higher level apps certainly could). |
Reply ·0 | |
|