commits/18516

Change 18516

mjoubert (mjoubert)
mjoubert modified this change 9 years ago into //guest/perforce_software/p4jenkins/main/src/main/java/org/jenkinsci/plugins/p4 under Review 18517
View Review
Download .zip
#review-18517 @pallen

Uncaught exception is thrown.

Looking at the code it could happen if there are multiple threads.
Might need a try catch as well.

Can't compile and test code , due to invalid pom so code might need a tweak

Mar 03, 2016 11:59:49 AM org.jenkins_ci.plugins.run_condition.BuildStepRunner logEvaluateException
WARNING: Exception caught evaluating condition: [java.lang.IllegalArgumentException: Null value not allowed as an environment variable: P4_TICKET], action = [Fail the build]
java.lang.IllegalArgumentException: Null value not allowed as an environment variable: P4_TICKET
        at hudson.EnvVars.put(EnvVars.java:356)
        at hudson.EnvVars.put(EnvVars.java:74)
        at org.jenkinsci.plugins.p4.PerforceScm.buildEnvVars(PerforceScm.java:402)
        at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:910)
        at org.jenkinsci.plugins.tokenmacro.TokenMacro.expandAll(TokenMacro.java:229)
        at org.jenkinsci.plugins.tokenmacro.TokenMacro.expandAll(TokenMacro.java:222)         at
Add Job
1 edited 0 added 0 deleted
Tip: Use n and p to cycle through the changes.