commits/8550

Change 8550

matt_attaway (Matt Attaway)
Matt Attaway committed this change 11 years ago into //guest/matt_attaway/p4nodeapi/src/cpp
Request Review
Download .zip
Improve control character handling in JSON strings

Previously we stripped out all newlines and left in numerous other control
characters that would result in errors with JSON.parse(). With this change
all control characters are kept and escaped following the guidelines at:

http://json.org
Add Job
1 edited 0 added 0 deleted
Tip: Use n and p to cycle through the changes.
matt_attaway (Matt Attaway)
Matt Attaway commented 11 years ago

@gabor_maghera, @lester_cheung Can you two check my logic? Based on the fact that my little web services app won't work with out this change I think it's sane, but I'd appreciate some more eyes. 😄
Reply
gabor_maghera (Gabor Maghera)
Gabor Maghera (on ) commented 11 years ago

Way to go! I had method in my program which would replace "\t" with "\t" in the output of p4nodeapi, before supplying it to JSON.parse() to work around the issue. Nice to see it fixed. Thank you, @matt_attaway!
Reply
matt_attaway (Matt Attaway)
Matt Attaway (on ) commented 11 years ago

Yeah, I was doing the same, and then I realized all my newlines were missing. I think tonight I'm going to strip out the 'fund' entries in the dictionary. I assume you aren't using them for anything?
Reply
gabor_maghera (Gabor Maghera)
Gabor Maghera (on ) commented 11 years ago

Umm, I'm not sure I know what they are. So, I'm probably not using them. 😃
Reply
lester_cheung (Lester Cheung)
Lester Cheung commented 11 years ago

@matt_attaway the change makes sense but I have yet to try the nodeapi - yet. Who's up for P4Web 2.0? :)
Reply
matt_attaway (Matt Attaway)
Matt Attaway commented 11 years ago

I think you're in it right now. It's called Swarm. 😄
Reply
lester_cheung (Lester Cheung)
Lester Cheung commented 11 years ago

😌
Reply